Skip okbuck if we just want to kill the buck daemon. #425
Conversation
buckw
Outdated
| @@ -191,6 +191,12 @@ setupBuckRun ( ) { | |||
| setupBuckBinary | |||
| } | |||
|
|
|||
| # Do not pass go, do not collect $200 go straight to kill - Skip okbuck if we just want to kill the buck daemon. | |||
| if [[ "kill" == "$1" ]]; | |||
There was a problem hiding this comment.
Can we move this to a method declaration? We can handle all the cases in '$1' explicitly then
There was a problem hiding this comment.
move it in to setupBuckRun() or its own method?
There was a problem hiding this comment.
separate method. Something like
handleCommands ( ) {
if [[ "$1" == "kill" ]]; then # Handle kill command
elif # handle other commands and so on
fi
}
|
Ok, updated to use a function. My bash script foo isn't very good so let me know if there's a better way to do this. |
buckw
Outdated
| if [[ "kill" == $1 ]]; then | ||
| SKIP_OKBUCK=true | ||
| fi | ||
| setupBuckRun |
There was a problem hiding this comment.
setupBuckRun should go just below the call to handleParams
There was a problem hiding this comment.
Can you move this below handleParams "$@"
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.5-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.5-all.zip |
There was a problem hiding this comment.
Do not need to change this
There was a problem hiding this comment.
Whoops, I think when the IDE asked if i wanted to use "distribution with sources" I said yes. We don't want the sources?
There was a problem hiding this comment.
It does not work ever since they generate an API jar for Gradle now. No point bloating up downloads in Travis and ppl working on it. Please change it back
There was a problem hiding this comment.
It does not work ever since they generate an API jar for Gradle now. No point bloating up downloads in Travis and ppl working on it. Please change it back
There was a problem hiding this comment.
Can you switch this back to bin as well? The rest looks good
buckw
Outdated
| setupBuckRun | ||
| # Handle parameters and flags | ||
| handleParams ( ) { | ||
| # Go directly to kill. Do not run okbuck, do not collect $200. |
There was a problem hiding this comment.
There was a problem hiding this comment.
That is cool, but please remove it :)
Prefer keeping it clean
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.5-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.5-all.zip |
There was a problem hiding this comment.
Can you switch this back to bin as well? The rest looks good
|
Alright, updated to remove $200 and use the binary distribution of the gradle wrapper. |
|
@kageiit this is "$200" FYI Do not collect $200
😛 |
* uber/master: Use stream instead of parallelStream (uber#437) Add empty resource rule if using resource union. (uber#438) Publich v0.20.7 Move okbuck task to its own gradle task class. (uber#436) Use try-with-resources (uber#432) Update README.md Do not allow okbuck to be run without okbuck.wrapper set to true. (uber#433) Set descriptions in tasks class instead of when creating them. (uber#431) Move cleaning the .okbuck/gen folder to the first step of setupOkbuck. (uber#430) Publish v0.20.6 Add support for downloading 22-25 API robolectric runtime dependencies. (uber#427) Skip okbuck if we just want to kill the buck daemon. (uber#425)
No description provided.