-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default adblock filter lists #1245
Comments
thank you for the detailed list. However, I anticipate the goals I would like to set for cromite:
regarding the last point is of fundamental importance, because the blocking made by the lists must not be at the expense of privacy or security: if you deactivate functions or scripts, they become nastier, like those of Google, who first try to display ads trying to preserve privacy and if they fail to do so, they don't give a damn and in order to show them, they exploit mechanisms that lead to sending private cookies from the site. additionally bypassing adblocks is easy and countermeasure methods ineffective or temporary. I can tell you from experience, I have tried it with #251 give me time to consider how to proceed. |
💯, I think this would be ideal. I wonder how other content blockers ex. uBlock Origin & AdGuard handle this with their built-in lists? I might try to research this myself. You're right, I think we need some kind of mechanism in place to protect against malicious or questionable rules.
Yes, 100%. I would much rather a more private & secure browser over slightly better ad blocking, I think most would agree.
Do you have any sources or more info on this? I wouldn't mind investigating this as a list maintainer myself to figure out the best way to handle such cases. What you say doesn't surprise me though.
Yeah, content blocking in general is a cat and mouse game :/. I just read through the issue, and I think it might be worth investigating if we could add the uBlock filters as well, since they're especially effective at this. I didn't mention them above though because I'm not sure how compatible they are with ABP, so that will need more investigation.
👍 Best to do this the right way rather than rushing into it, I agree that we should always put privacy & security first. If there's anything that I can do to help from my end as a list maintainer, please let me know. |
personally tried, no, I don't think there is anything on the Internet.
I will get back to that issue and let you know.
be sure of it! |
Oh no, please don't add those blocklists or enable them by default. I once experienced a case where websites/domains could not be accessed after trying to add Hagezi Threat Intelligence Feeds and others (forgot which ones) to my OpenWRT router. You need an admin if you want to use aggressive blocklists and that's not good for end users. I don't have many tried filter lists other than oisd and hagezi. Also, those lists can simply be handled/managed by app such as rethinkdns, personaldnsfilter, invizible pro and others for system-wide not just the browser. Honestly, I just want you to add these lists to the default filter so I don't have to add them manually: I've asked for it here #879 (comment) |
This is not intentional at all and I would highly recommend you report any false positives to Hagezi. I've personally never encountered any false positives from TIF, due to the careful curation & high quality sources. I'm not sure how long ago you used it, so it might be worth trying again, and again, please report any false positives if you experience them.
My guess would be the
I generally agree, I think we should focus on enabling lists known to not cause breakage by default, and maybe we could also include some more aggressive lists, but just not enable them by default & leave to the end user to decide (Like ex. uBlock Origin & AdGuard do for instance). I feel like most of the lists I mentioned are generally safe and shouldn't cause issues, with the main exception of
I agree that some of these lists are best used at a DNS level, but we can't count on the majority of average users having DNS protection in place (not to mention also having the specific desired list). Therefore, I think it'd be a good idea to still include some domain lists like this (Other content blockers such as uBlock Origin & AdGuard also include some domain lists), but I agree, we also need more advanced lists as well, such as potentially the uBlock Origin filters if they are compatible.
I agree with |
As you said add to default doesn't mean enable by default. |
Ah, apologies @wildbeetle I misunderstood your point. I 100% agree that |
actually what I want is just to enable them by default, so that cromite appears to behave the same. |
Hello again @uazo @Retold3202 Forgot to mention TIF IP too. |
Great to hear! :) |
I'd like to cast light on the domain count of these blocklists since Cromite is supported Android 7+ Here are some of the Blocklist lists with their respective domain counts:EasyList 85k+ Here are some resources to consider:List of Blocklists Intended for Mobile Devices We absolutely have to consider every user since Cromite is a web browser primarily used on wide variety of mobile devices. |
You're correct - I don't think that we should necessarily enable all of the lists I mentioned by default, but rather we can just add them as options for the user to decide. I definitely should've laid that out better though. As far as for lists we should enable by default for every user - I think as a starting point, this should look something like:
These are probably the most important lists IMO. I'd be interested to see data benchmarking these though and how they can impact lower end devices, probably needs testing. My personal experience using these (+ more lists...) enabled in uBlock Origin on a Pixel 7 Pro was very solid without issues, but obviously that's a higher end device and we can't expect that to be everyone's experience. |
I think we can safely enable by default HaGeZi's Pro mini, Actually Legitimate URL Shortener Tool and maybe HaGeZi's TIF Medium??? I would like to add Badblock+ by default as well if it breaks no functionality. I would like you to better explain how Badblock+ would benefit users who already use better known lists. I think Mull Browser's user base and especially it's maintainer could help us enormously on performance impact of lists. They have been using uBlock w/ default uBlock lists for years. @SkewedZeppelin |
Sure. A lot of BadBlock’s benefit/appeal comes down to the fact that our lists are more comprehensive than a lot of others out there that try to avoid breakage at all costs - BadBlock tries to avoid breakage where possible, but if the ends justify the means and there’a a large privacy/security impact, then we will block what is needed. Also worth noting that every entry is manually researched and reviewed by me first, unlike most lists that just compile together a bunch of other blocklists. It’s not the biggest list in the world due to this, but I guess it’s sort of a quality vs. quantity sort of thing. None of the BadBlock lists should be relied on as the sole blocklist, but I think they are nice as complementary lists to other more widely used ones. I’d encourage you check out the README if you haven’t already, since it goes much more in depth than I am here - I’m probably not doing this justice. Please let me know if you think I should update it or change anything! Also happy to answer any other questions you have :)
Good thinking. I also wonder how efficient Cromite’s ABP is compared to uBlock Origin on mobile… |
The low end device I have now is only Redmi 9 with 3GB RAM. And the filters I use on cromite. Default:
Custom: Of course there is no problem on my more powerful device (S23+). :) |
I have been trying for some time BadBlock plus, excellent but lately unfortunately breaks a few sites (like creepjs which I use for testing). |
My thinking behind blocking it was to prevent ex. 3rd party sites from abusing it for fingerprinting - I should probably adjust it to 3p since you're right that it is useful for testing... |
In my opinion, using hagezi filters as an additional list is enough. |
Another list to consider is @Kees1958's most used trackers list, I have been using it alongside Ad-Void, Badblock Plus, and my ABP format forks of @yokoffing's lists without issue for a while now. I also deactivated EasyList and EasyPrivacy, and added @ryanbr's Fanboy Ultimate list for wider coverage with less lists. I use a similar setup with uBlock Origin on the Windows version of Cromite, FWIW, but YMMV. See: |
While I am here, I thought I would also recommend some default user scripts, I have been using these without issue also; I Don't Care About Cookies for Bromite by @xarantolus (on Android): AdGuard Extra by AdGuard (on Windows and Android): Remove URL tracking by @KokichaKolevTM (on Android): I also use BPC. Won't name it or link it here, as GitHub has repeatedly allowed malicious DMCAs against it, but IYKYK. |
Let's try to keep it simple, minimal and most importantly always prefer established, actively maintained, lists that are well tested by many users. I don't think uazo would try to test all these lists. Frankly I think it would be a massive waste of time FOR cromite project. |
no, you're right, I won't.
It is very important to have common predefined lists that work, so that we all look the same since are detectable by sites. |
Honestly study Brave Browser's default filter lists(link below) and enable those and be done with it. No need to reinvent the wheel and waste any more time. https://github.com/brave/adblock-resources/blob/master/filter_lists/list_catalog.json |
After failure to block adblock warning in Cromite with https://easylist-downloads.adblockplus.org/antiadblockfilters.txt I've tried https://raw.githubusercontent.com/bogachenko/fuckfuckadblock/master/fuckfuckadblock.txt?_=rawlist. It worked, but given problems with some other news streaming site. Then I applied Badblock and seems it working better. Even I had to disable Cromite's inbuilt easy privacy list as it blocking picture loading in some site, but with Bad block thease not happening. And last of all, https://d3ward.github.io/toolz/adblock shows 97% blocking of contents, which was 85% with all inbuilt filters active. May Uazo and other knowledgeable persons test more on Badblock. Greetings. |
Following up from #1237, I'll give my thoughts regarding filter lists we should consider adding or enabling by default:
To start, I think we should keep EasyList & EasyPrivacy enabled by default. These are both very high quality & well respected lists, & great at blocking undesired content. They also make nice use of the ABP syntax.
So first, I think it'd be a great idea to add HaGeZi's Threat Intelligence Feeds. This is a very comprehensive & effective list at blocking malicious domains, and it would help to make up for the lack of Safe Browsing. Similarly, he also has a list for Malicious IPs, which I also think would be worth including.
Some of HaGeZi's other lists could be considered as well, such as his Dynamic DNS blocking & Badware Hoster blocking. I think his Multi ULTIMATE or Multi Pro++ lists could also make nice additions.
Another list I'd like to suggest considering is my BadBlock project, specifically my BadBlock+ list. This is a very carefully curated & high quality list that goes above and beyond most others. Every domain added is carefully researched & considered, as to avoid false positives. I also make nice use of wildcards & the ABP Syntax. Overall, it's very comprehensive, and I'm putting a lot of effort into growing & expanding it as much as possible, and I think it'd make another very nice addition to Cromite's filters.
I think it'd also be worth including the Divested Combined Blocklist. This is a list maintained by Divested Computing Group (behind ex. DivestOS, Mull, Mulch, Hypatia, etc). and includes a variety of high quality sources, and has nice coverage that most other lists seem to miss. They also have a Fingerprinting blocklist that I think would also make a nice addition if its compatible.
Another list that could be considered is the Actually Legitimate URL Shortener Tool. It is very effective at removing tracking parameters from URLs. My only concern would be that I'm unsure if it's compatible with Cromite's ABP or not, would require testing. I think it could also be worth adding Dandelion Sprout's Anti-Malware List, for similar reasons to HaGeZi's Threat Intelligence Feeds.
I think it'd also be worth including EasyList Cookie. This is great at blocking obnoxious cookie banners and improving privacy.
Additionally, while I'm not sure if it should be enabled by default, I think it'd also be worth at least including Yokoffing's 'Block third party fonts' list. This blocks unnecessary fonts used for tracking on webpages, while also unbreaking pages that legitimately need them.
Another list we could consider adding but not enabling by default is 1Hosts Pro. This is another nice and comprehensive list that I personally use, but it does tend to cause breakage from time to time, so that's why I'd be reluctant enabling it by default.
I think that this is a nice starting point for a discussion, and I'd be curious to hear your thoughts as well as what anyone else has to say or suggest.
The text was updated successfully, but these errors were encountered: