-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom "Allow Snippets" toggle for Adblock Plus #1528
Comments
interesting but lacking an explanation of why those rules are needed and what they deactivate. |
Allow me to point you to some relevant documentation! https://help.adblockplus.org/hc/en-us/articles/1500002338501-Snippet-filters-tutorial https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#scriptlet-injection |
sorry, perhaps I have not made myself clear. |
For that, you would be best speaking to @igorskyflyer, but from what I understand, they are rules specifically designed to fight more advanced anti-adblock systems. Also, this feature request isn't just about these specific snippet rules, but rather, the wider scope of them in general. A lot of paywall bypassing filterlists use them, as well as anti-cookie banner lists. They have become somewhat necessary nowadays for most things. uBlock's uAssets lists are full of ++js rules. TLDR; I am suggesting we globally enable snippets but allow user control of what lists can use them as a middle ground between security, usability, and privacy, as uBlock allows them, AdGuard allows them, so I don't see what is stopping us. |
I don't completely disagree with the feasibility of leaving the choice up to the user, but I would first like to understand whether it would be appropriate to activate those filters by default for everyone, since use would allow the page to understand the presence of the list. |
Hello, I am the mentioned author of the given scriptlets. The provided scriptlets block those anti-Adblock popups that block the user completely from using the site without disabling their Adblocker, i.e.: Note The mentioned scriptlets are global (apply to any site), there are also site-specific ones, for reference: AdVoid.Core.Scriptlets and AdVoid.Addon.NoAnnoyances.Scriptlets. Hope that this clears it why it's important to add them as a feature (if possible). If you have any more questions, feel free to ask.
|
I can understand the usefulness of having snippets, but being able to inject JS does seem to have some valid privacy & security concerns. Personally, I think an ideal solution here could maybe be to:
|
@igorskyflyer thank you, that's what I was looking for.
yes, but not everything is allowed in cromite.
@celenityy is already like that.
I would prefer to have default lists for all users (like your work in #1245, by the way, excuse me, but I did not forget).
exactly. and not only that, all changes made in javascript are a source for fingerprinting. |
Preliminary checklist
Is your feature request related to privacy?
Yes
Is there a patch available for this feature somewhere?
It should be possible to patch the Adblock Plus code itself to achieve this
Describe the solution you would like
Considering the lack of extension support for the Android version of Cromite (we can only block ads with Adblock Plus), I believe it is essential to be able to allow scriptlet rules for third party lists that we trust.
For example, I use BadBlock by @celenityy as well as Ad-Void by @igorskyflyer in my custom lists, one of which, Ad-Void, has various scriptlet rules that would be overall beneficial to enhance ABP's blocking capabilities.
See:
https://raw.githubusercontent.com/the-advoid/ad-void/refs/heads/main/scriptlets/AdVoid.Scriptlets.AntiAntiAdBlock.txt
Additionally, AdGuard and uBlock already allow third party lists to define scriptlet rules, and uBlock also has a toggle to allow "custom rules requiring trust", so ABP is behind them in terms of capabilities currently.
TLDR: I think it would be beneficial to add a submenu to the scriptlets toggle to allow third party URLs to add scriptlet rules.
Describe alternatives you have considered
Not possible
The text was updated successfully, but these errors were encountered: