-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed all objects under a Module/Namespace onto single page #338
Comments
I have been looking at this on the next branch but haven't had time to bring it forward. The idea would be for user to specify what symbols to hoist onto a single page using a hasOwnDocument option. Experimental currently.
The idea is that when the theme iterates over reflections from the model it would go through a mapping map in a similar way that the html theme does. https://github.com/tgreyuk/typedoc-plugin-markdown/blob/next/packages/typedoc-plugin-markdown/src/theme.ts#L194 Feel free to take a look, or even branch off the next branch as the architecture has changed a bit. |
Ah, didn't see the
|
:) i really want to get it out a.s.a.p but i haven't tested it enough and it all feels a bit exprimental. It would be fantastic to get another pair of eyes on it. There is no harm in pushing it out as a 4.0@beta and not advertise it. Id be interested what you think (sorry I haven't written any docs for it yet and the tests are probably all failing but i can look at that). Main bits are:
|
A published beta would make testing a lot easier, local NPM packages are no fun especially when you attempt to make it work with CI :D |
I've found one bug so far where |
Two more bugs I've found:
More than happy to put in a PR for these if you have a quick direction for me to check out. |
Put in a PR for the comment issue, not 100% sure if you'd like it solved that way but it's close to how the old impl was done. I tried to dig into the |
@tgreyuk I've spent a good chunk of time the past few days getting the We also made some more subjective formatting changes that I feel could be good improvements, but not sure of the best way to discuss if those are things you'd like a PR, issue, etc. for or not. |
@tgreyuk you mentioned about putting out a beta on NPM of |
Yeah - sorry. I was busy on something else but am now focussed on this
project again. The branches have diverged quite a bit and i just need to
make sure i've not lost anything in the transition.
…On Sat, 3 Dec 2022 at 13:55, Lorenzo Lewis ***@***.***> wrote:
@tgreyuk <https://github.com/tgreyuk> you mentioned about putting out a
beta on NPM of next, is there anything I can do to push towards that and
help out?
—
Reply to this email directly, view it on GitHub
<#338 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZDYZRT6N3XYWDT7MFJZCDWLNGL5ANCNFSM56QSEFMA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I'm happy to test this out as well when/if ready! I want to be able to have interfaces, type aliases, functions, parameters on the module page, instead of linking to a different one on authjs.dev. Currently, this is how it looks like: https://auth-docs-git-chore-reference-sidebar-authjs.vercel.app/reference/core/modules/jwt. For now, I came up with a hack, but it is rendering titles a bit redundant, and interfaces are just Disclaimer: Great work! 💚 |
* wip * 🤖 lazy commit * 🤖 lazy commit * revert some changes, remove prettier jsdoc plugin for now * sidebar tweaks * add adapter module docs * remove provider docs * embed all reflections under modules Based on: TypeStrong/typedoc#2006 Related: typedoc2md/typedoc-plugin-markdown#338 * no trailing slash, update theme * updates * update snapshot * update sidebar and overview
I've been looking more into this lately, and I was checking out the Some feedback:
I am still happy to be an early tester, if you need help, let me know, and I would also like to sponsor you or the project if you accept it. 💚 |
Why doesn't Edit: nvm I figured it out:
very clean and readable output |
I see the undocumented flag
allReflectionsHaveOwnDocument
. Is there a way to extend this to also work for Enums, Classes, and Interfaces so that essentially everything under a module/namespace is all on a single page?I moved around the objects here https://github.com/tgreyuk/typedoc-plugin-markdown/blob/master/packages/typedoc-plugin-markdown/src/theme.ts#L328-L338 but the resulting output just renders those more... complicated items as
Object
in the output.I'm assuming this would have to adjust how the templates are structured. This is something I'm working on in my fork so happy for any advice on this and can open a PR once it's setup if you'd like.
The text was updated successfully, but these errors were encountered: