Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: /reference sidebar improvements #6115

Merged
merged 12 commits into from
Dec 19, 2022
Merged

docs: /reference sidebar improvements #6115

merged 12 commits into from
Dec 19, 2022

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Dec 18, 2022 •
edited
Loading

@vercel
Copy link

vercel bot commented Dec 18, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 19, 2022 at 0:52AM (UTC)
2 Ignored Deployments
Name Status Preview Comments Updated
next-auth ⬜️ Ignored (Inspect) Dec 19, 2022 at 0:52AM (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Dec 19, 2022 at 0:52AM (UTC)

@balazsorban44 balazsorban44 marked this pull request as ready for review December 19, 2022 00:39
@balazsorban44 balazsorban44 changed the title docs: /reference sidebar improvements (WIP) docs: /reference sidebar improvements Dec 19, 2022
@ndom91
Copy link
Member

ndom91 commented Dec 19, 2022

Small nit, the Reference index page and the "experimental" emojis in the sidebar are a bit confusing.

I know we're tryign to say that the @auth/nextjs package itself is experimental int he sidebar, and with the index page saying that Next.js support generally (via the "old" package) is stable. But an average user isn't going to know that..

image

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters mikro-orm @auth/mikro-orm-adapter labels Dec 19, 2022
@balazsorban44 balazsorban44 merged commit e699ff1 into main Dec 19, 2022
@balazsorban44 balazsorban44 deleted the chore/reference-sidebar branch December 19, 2022 01:00
@naiba4 naiba4 mentioned this pull request Nov 28, 2023
Open
@naiba4 naiba4 mentioned this pull request Feb 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndom91 ndom91 ndom91 approved these changes

@ubbe-xyz ubbe-xyz Awaiting requested review from ubbe-xyz ubbe-xyz is a code owner

@ThangHuuVu ThangHuuVu Awaiting requested review from ThangHuuVu ThangHuuVu is a code owner

Assignees
No one assigned
Labels
adapters Changes related to the core code concerning database adapters mikro-orm @auth/mikro-orm-adapter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balazsorban44 @ndom91