-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add playback module #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently these commands are only being used during playback and recording to ENABLE required modules. For example, when we enter playback mode on the PC script, it first sends a command to the microcontroller to enable servos. Similarly, when we enter recording mode on the PC script, it first sends a command to enable IMU sensing. This is done so that the user of the PC script doesn't have to issue more than one command to initiate a test in a desired mode. Hence, although the servo and IMU enable/disable commands are available directly from the command-line, their effects will always be overwritten as soon as recording or playback command is issued. In the future, we could also send a command to disable servos when we are recording, and send a command to disable IMU sensing when we are in playback mode. Commands could also be added to enable/disable transmissions from the MCU to the PC, since these transmissions are discarded when in playback mode and are only needed in recording mode. At the moment, the microcontroller disables servo actuation when it is first powered up, so it basically defaults into recording mode, and it requires a command to start servo actuation. This is a safety feature more than anything else, because it means that upon powering up the MCU, the servos will not automatically start moving
This was referenced Jul 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29