Update to Bazel 1.1 #1142
Merged
Update to Bazel 1.1 #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherrmann
force-pushed
the
bazel-1.1
branch
2 times, most recently
from
b52aa23 to
ef5c7c0
Compare
mboes
reviewed
Nov 14, 2019
.netlify/build.sh
Outdated
| # XXX: see .bazelrc note [backward compatible options] for rational behind | ||
| # the --incompatible_use_python_toolchains flag | ||
| bazel build --incompatible_use_python_toolchains=false //docs:api_html | ||
| # XXX: Remove --host_force_python=PY2 after updating to Starlark 0.4.0 |
There was a problem hiding this comment.
What's Starlark 0.4? Is the language now versioned separately from Bazel?
There was a problem hiding this comment.
Changes below suggest you meant Stardoc.
There was a problem hiding this comment.
Good catch. Yes, I meant stardoc.
mboes
approved these changes
Nov 14, 2019
WORKSPACE
Outdated
| #) | ||
| nixpkgs_package( | ||
| name = "python3", | ||
| attribute_path = "python3", |
There was a problem hiding this comment.
Nit: I believe this line is line is redundant.
.netlify/build.sh
Outdated
| # XXX: see .bazelrc note [backward compatible options] for rational behind | ||
| # the --incompatible_use_python_toolchains flag | ||
| bazel build --incompatible_use_python_toolchains=false //docs:api_html | ||
| # XXX: Remove --host_force_python=PY2 after updating to Starlark 0.4.0 |
There was a problem hiding this comment.
Changes below suggest you meant Stardoc.
WORKSPACE
Outdated
| ) | ||
|
|
||
| nixpkgs_python_configure( | ||
| # XXX: Remove python2_attribute_path after updating to Starlark 0.4.0 |
There was a problem hiding this comment.
Same as above: did you mean Stardoc?
haskell/repositories.bzl
Outdated
| strip_prefix = "rules_nixpkgs-0.5.2", | ||
| urls = ["https://github.com/tweag/rules_nixpkgs/archive/v0.5.2.tar.gz"], | ||
| sha256 = "b13cb651e972b3aa06bab75603923071d7647c9ee3f8acb707e3831aa606e911", | ||
| strip_prefix = "rules_nixpkgs-bdc802f8e716c66d50cc91f7ad22505edf13c48b", |
There was a problem hiding this comment.
Ideally we should cut a new release of upstream.
This was referenced Nov 14, 2019
aherrmann
force-pushed
the
pipeline-bazel-version
branch
from
d982e79 to
e562d98
Compare
jwiegley
force-pushed
the
pipeline-bazel-version
branch
from
e562d98 to
63218cd
Compare
Nixpkgs `haskellPackages` provides `proto-lens-protoc` 0.5. `proto-lens` 0.5 appears in stackage `lts-14`.
To include nixpkgs_python_configure
The examples and tutorial repository have been added to `.bazelignore` before, however, the local repositories remained defined. These are not used anywhere and can be removed.
The skydoc repository has been deprecated, see https://github.com/bazelbuild/skydoc/releases/tag/0.3.0 Skydoc has also been deprecated in favor of Stardoc, however the API changed, so we're not updating to Stardoc 0.4.0, yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1141 change base branch before merging
This is based on and replaces #1065.
rules_nixpkgsto includenixpkgs_python_configure.nixpkgs_python_configureto avoid issues with the Python toolchain as described in Bump stackage nixpkgs + bazel 0.29 #1065.Defines an alias to be backwards compatible to users depending on that platform constraint.
Closes #1065.