-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use_default_shell_env #1143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w00t! Depending on whether this or #1142 gets merged first, the comment in the CI setup for the bindist case should be updated accordingly.
This PR transitively depends on #1142 through #1136
Yes, I'll rebase and adapt the comment. Unfortunately, we cannot remove the flag, yet. |
We should send them a PR to get them to use |
d589ce1
to
b8f4b6d
Compare
Turns out they're not using |
I opened protocolbuffers/protobuf#6886 to propose reverting protocolbuffers/protobuf#2933. |
b8f4b6d
to
ae3b7b9
Compare
ae3b7b9
to
e595071
Compare
netlify got stuck. Force pushed to kick it. |
depends on #1136 change base branch before merging
use_default_shell_env = True
.Replaces them using the POSIX toolchain provided by
rules_sh
.C:\Program Files\...
.This requires additional quoting in some places.