Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stackage nixpkgs + bazel 0.29 #1065

Closed
wants to merge 3 commits into from
Closed

Conversation

guibou
Copy link
Contributor

@guibou guibou commented Sep 1, 2019

Note: this is a work in progress, because nixpkgs introduced a regression in the way bazel handle python path and this should be fixed first. From my point of view, rules_haskell is ready for bazel 0.29, but not with the bazel from nixpkgs.

@guibou guibou force-pushed the bump_stackage_nixpkgs branch from a7963a5 to 0882c7c Compare September 1, 2019 14:51
@Profpatsch
Copy link
Contributor

Profpatsch commented Sep 3, 2019

The MAINTAINERS file has a checklist for bumping bazel:

  • Bump bazel download link for bazel in .circleci/config.yml
  • Bump bazel download link for bazel in azure-pipelines.yml
  • Update all bazel rules dependencies in WORKSPACE (e.g.
    io_bazel_skydoc)
  • Update bazel in nixpkgs and bump nixpkgs/default.nix
  • Bump MAX_BAZEL_* in start
  • If we are updating to a new LTS:
    • Bump MIN_BAZEL_* in start
    • TODO
  • Add update notice to CHANGELOG

Nixpkgs `haskellPackages` provides `proto-lens-protoc` 0.5. `proto-lens`
0.5 appears in stackage `lts-14`.
@guibou guibou force-pushed the bump_stackage_nixpkgs branch from a90c7aa to 24b9d64 Compare September 3, 2019 16:47
@guibou guibou force-pushed the bump_stackage_nixpkgs branch 2 times, most recently from ac05def to 55b0375 Compare September 4, 2019 09:21
@guibou guibou force-pushed the bump_stackage_nixpkgs branch from 55b0375 to 59f9336 Compare September 5, 2019 17:54
@mboes
Copy link
Member

mboes commented Sep 17, 2019

Are we there yet?

@guibou
Copy link
Contributor Author

guibou commented Sep 17, 2019

@mboes Unfortunately no. I did not find the time to work on that, especially considering that the issue won't appear if we are using an official bazel release or if we are using bazel from nixpkgs in a nix context.

@Profpatsch
Copy link
Contributor

Can we get this merged? Or does it make sense to just wait for 1.0 by now?

@guibou
Copy link
Contributor Author

guibou commented Oct 7, 2019

@Profpatsch This is not mergable in the current state. We either need to:

  • Fix bazel in nixpkgs to work propertly with system provided python (and others)
  • Conditionnaly use the python toolchain on linux_nixpkgs and use the system toolchain in other context. I still don't know how to do that.

@guibou
Copy link
Contributor Author

guibou commented Oct 7, 2019

Please note that the issue is just with bazel from nixpkgs. Rules_haskell is compatible with bazel 0.29 without this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants