-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump stackage nixpkgs + bazel 0.29 #1065
Conversation
a7963a5
to
0882c7c
Compare
The
|
Nixpkgs `haskellPackages` provides `proto-lens-protoc` 0.5. `proto-lens` 0.5 appears in stackage `lts-14`.
a90c7aa
to
24b9d64
Compare
ac05def
to
55b0375
Compare
55b0375
to
59f9336
Compare
Are we there yet? |
@mboes Unfortunately no. I did not find the time to work on that, especially considering that the issue won't appear if we are using an official bazel release or if we are using bazel from nixpkgs in a nix context. |
Can we get this merged? Or does it make sense to just wait for 1.0 by now? |
@Profpatsch This is not mergable in the current state. We either need to:
|
Please note that the issue is just with bazel from nixpkgs. Rules_haskell is compatible with bazel 0.29 without this pull request. |
Stackage + nixpkgs are bumped together to get similar version of
proto-lens
andproto-lens-protoc
.Bazel 0.29 comes from the current PR: bazel: 0.28.1 -> 0.29.0 NixOS/nixpkgs#67835
Note: this is a work in progress, because nixpkgs introduced a regression in the way bazel handle python path and this should be fixed first. From my point of view, rules_haskell is ready for bazel 0.29, but not with the bazel from nixpkgs.