-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for successful windows build #121
Conversation
Needed for successful tremor build on windows. Also, it is the preferred way of building rdkafka: https://github.com/fede1024/rust-rdkafka/tree/v0.23.0#installation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merge ahead :) when green
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
+ Coverage 68.97% 68.97% +<.01%
==========================================
Files 125 125
Lines 13883 13896 +13
==========================================
+ Hits 9576 9585 +9
- Misses 4307 4311 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested via doing a full release build from a native windows machine.
Instructions for windows builds are being added via: tremor-rs/tremor-www-docs#10