Fixes for successful windows build

Cargo.toml

@@ -79,8 +79,8 @@ postgres = { version = "0.17.2", features = ["with-serde_json-1", "with-chrono-0
 postgres-protocol = "0.5" 
 tokio-postgres = "0.5"
 
-# kafka
-rdkafka = "0.23"
+# kafka. cmake is the encouraged way to build this and also the one that works on windows.
+rdkafka = { version = "0.23", features = ["cmake-build"] }
 
 # crononome
 cron = "0.6.0"

README.md

@@ -1,4 +1,6 @@
-# Tremor   [![Build Status]][actions-Tests] [![Quality Checks]][actions-Checks] [![License Checks]][actions-License-audit] [![Security Checks]][actions-Security-audit] [![Code Coverage]][codecov.io] [![Dependabot Status]][dependabot.com]
+# Tremor
+
+[![Build Status]][actions-Tests] [![Quality Checks]][actions-Checks] [![License Checks]][actions-License-audit] [![Security Checks]][actions-Security-audit] [![Code Coverage]][codecov.io] [![Dependabot Status]][dependabot.com]
 
 [Build Status]: https://github.com/wayfair-tremor/tremor-runtime/workflows/Tests/badge.svg
 [actions-Tests]: https://github.com/wayfair-tremor/tremor-runtime/actions?query=workflow%3ATests
@@ -15,7 +17,7 @@
 
 ---
 
-In short, tremor is an event processing system. It was originally designed as a replacement for software such as [Logstash](https://www.elastic.co/products/logstash) or [Telegraf](https://www.influxdata.com/time-series-platform/telegraf/). However tremor has outgrown this singular use case by supporting more complex workflows such as aggregation, rollups, an ETL language, and a query language. 
+In short, Tremor is an event processing system. It was originally designed as a replacement for software such as [Logstash](https://www.elastic.co/products/logstash) or [Telegraf](https://www.influxdata.com/time-series-platform/telegraf/). However tremor has outgrown this singular use case by supporting more complex workflows such as aggregation, rollups, an ETL language, and a query language.
 
 More about the [history](https://docs.tremor.rs/history/) and [architecture](dochttps://docs.tremor.rs/overview/) can be found in [the documentation](https://docs.tremor.rs/).
 
@@ -61,9 +63,11 @@ Note that sice the image is building tremor in release mode it requires some ser
 
 ### Local builds
 
-If you are not comfortable with managing library packages on your system or don't have experience with , please use the Docker image provided above. Local builds are not supported and purely at your own risk.
+If you are not comfortable with managing library packages on your system or don't have experience with, please use the Docker image provided above. Local builds are not supported and purely at your own risk.
+
+For local builds, tremor requires rust 2018 (version `1.31` or later), along with all the tools needed to build rust programs. Eg: for centos, the packages `gcc`, `make`, `cmake`, `clang`, `openssl`, and `libstdc++` are required. For different distributions or operating systems, please install the packages accordingly.
 
-For local builds, tremor requires rust 2018 (version `1.31` or later), along with all the tools needed to build rust programs. For centos the packages `gcc`, `make`, `cmake`, `clang`, `openssl`, and `libstdc++` are required, for different distributions or operating systems, please install packages accordingly.
+For a more detailed guide on local builds, please refer to the [tremor development docs](https://docs.tremor.rs/development/quick-start/).
 
 ## Running locally
 
@@ -188,9 +192,3 @@ To execute a benchmark, build tremor in **release** mode and run the examples fr
 ```bash
 ./bench/run <name>
 ```
-
-### Ubuntu
-
-```bash
-sudo apt install git libssl-dev llvm-9-dev libclang-dev cmake
-```

src/errors.rs

@@ -124,7 +124,7 @@ error_chain! {
         YAMLError(serde_yaml::Error) #[doc = "Error during yaml parsing"];
         JSONError(simd_json::Error);
         SerdeError(serde_json::Error);
-        Io(std::io::Error) #[cfg(unix)];
+        Io(std::io::Error);
         SinkDequeueError(async_sink::SinkDequeueError);
         SinkEnqueueError(async_sink::SinkEnqueueError);
         FromUTF8Error(std::string::FromUtf8Error);

src/preprocessor.rs

@@ -68,7 +68,7 @@ impl SliceTrim for [u8] {
 
         if let Some(first) = self.iter().position(is_not_whitespace) {
             if let Some(last) = self.iter().rposition(is_not_whitespace) {
-                &self[first..last + 1]
+                &self[first..=last]
             } else {
                 &self[first..]
             }

tremor-api/src/api.rs

@@ -125,7 +125,7 @@ pub fn accept(req: &Request) -> ResourceType {
     // TODO implement correctly / RFC compliance
     match req.header("Accept") {
         Some("application/yaml") => ResourceType::Yaml,
-        Some("application/json") | _ => ResourceType::Json,
+        _ => ResourceType::Json,
     }
 }
 

tremor-pipeline/src/errors.rs

@@ -40,7 +40,7 @@ error_chain! {
         YAMLError(serde_yaml::Error) #[doc = "Error during yaml parsing"];
         JSONError(simd_json::Error);
         SerdeError(serde_json::Error);
-        Io(std::io::Error) #[cfg(unix)];
+        Io(std::io::Error);
         FromUTF8Error(std::string::FromUtf8Error);
         UTF8Error(std::str::Utf8Error);
         ParseIntError(std::num::ParseIntError);

tremor-tool/src/main.rs

@@ -138,7 +138,7 @@ impl<'a> TremorApp<'a> {
             .get_matches();
         let format = match cmd.value_of("format") {
             Some("json") => FormatKind::Json,
-            Some("yaml") | _ => FormatKind::Yaml,
+            _ => FormatKind::Yaml,
         };
         Ok(Self {
             app: cmd,
@@ -463,7 +463,7 @@ async fn conductor_version_cmd(app: &TremorApp<'_>, cmd: &ArgMatches<'_>) -> Res
         "{}",
         match cmd.value_of("format") {
             Some("yaml") => serde_yaml::to_string(&version)?,
-            Some("json") | _ => serde_json::to_string(&version)?,
+            _ => serde_json::to_string(&version)?,
         }
     );
     Ok(())