test pull #3
Merged
test pull #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds support for parentAccount property * Now with tests! And cleaned up the code * Slight cleanup of effectivePubID() * Further refinement to effectivePubID()
* tappx bidder base * Tappx Bidder v1.0 * added host parameter * tappx endpoint to macros * tappx bidder v1.0 final * fix formatting * added list of adapters without syncer * requested fixes
* going out real quick, brb * brb to attend 395 * Test cases still not ready, but touching base to see if we are on the right track here * removed some commented lines * Counting Imp types inside go_metrics.RecordImps function * Added >0 check in go_metrics.RecordImps * working on the prometheus part * going out real quick * Finally working as a counterVector for banner. Replicate for the others * Prometheus implemented * Test case for RecordImps() function * refactored imp types to be boolean values inside a new ImpLabels type * refactoring prometheus.go * Hans' refactoring and RecordLegacyImps() implemented * corrected .travis.yml * trying to fix travis issue * Small changes after Mansi's review
…in bid request (#968) * Omitempty on 'Target json.RawMessage' to avoid sending invalid in bid request * Omit empty additional fields
-Added null cj=hecks for Site and App -Added required fields validation: Site: id or page, App: id or bundle
* Initial changes * OneMobile adapter implementation * Updated the MakeRequests func for OneMobileAdapter * Fix race tests for onemobile adapter * Review updates and rename to verizonmedia * Fixed formated file * Review comments update * Review comments update seatbid length check
* new mgid adapter * increase coverage * remove extra imports * [mgid] optional placementId
* ignore swp files * start small * start really small * add a user sync * justify * triplelift adapter * add our endpoint * fix syntax * config stuff * compiler fixes * more config * add params * making progress * make our ext more exty * start making responses * more logic * fix compilation errors * can we just nil this out? * augment our json * radically simplify our json * fix errs * infer the bid type * fix syntax * fix comilation errors * rename * fix compilation error * config stuff * simplify params * more config stuff * fixes * revert this * fix up the extension * getting closer * add a test * update config * update bidder params * add the floor here, too * add a usersync test * validation, ws, and a test * update tests * fix test * update email * why not * change email * preprocess requests * do some parsing * take care of some errors * floor is optional * ws * remove native * everything is either banner or video * this should be a float * floor to floor * fix compilation errors * add some tests * more tests * more tests * simplify * more progress * format * ws * rm * don't need this * fix test * fix test * don't ignore swap * change line back * report an error if there are no valid impressions for triplelift * check for either a Banner or Video object on the impression * more tests * mv * more tests
* added tappx bidder doc * tappx doc revision
* Shift the metrics collection rate from one datapoint every 10 seconds to one every 20 * rolling back histogram change * some prometheus research * InfluxDB changes only
Do not forward imp.id as imp.tagId
Couple things here and there
also edited all examples so they include the full openRTB context
* nanointeractive adapter * nanointeractive adapter, changes after review * nanointeractive adapter * nanointeractive adapter, changes after review * formatting
* Fix Typo * Fixed More Typos
got this info from email communication with kidoz
* Add Cropping of BAdv for Rubicon Adapter BAdv size is limited to 50 * Fix after review Co-authored-by: Harbar Dmytro <[email protected]>
Co-authored-by: Veronika Solovei <[email protected]>
* TELARIA adapter. First Pass * Some refactoring * added the json files * fixed some tests and added the bidder info * fixed some tests and added the bidder info * added default user sync ur; * - Handling gzipped responses from our server * - more refactoring. * added the proper user sync default URL * changed the urls from dev to prod * changed up the required fields. Now AdCode in the Imp.Ext isn't required but Bid.SeatCode is required * change in the return type after decompressing * some refactoring * change in our config url * using pbs.yml to switch between our production and test URLs * setting default endpoint * - fixed the issue that was preventing telaria test cases to run. - added more test cases * - Modifications as per the changes requested by the maintainers. * Moved the seat code to imp.ext * Moved the seat code to imp.ext * Added 'Telaria: ' prefix for error messages * - Fixes for race conditions. Was modifying the original request object instead of a copy * cosmetic changes. * added params_test.go Co-authored-by: Vinay Prasad <[email protected]>
Co-authored-by: Veronika Solovei <[email protected]>
* Add missing categories to AppNexus -> IAB mapping file. * Remove entry for category 38 which was set to a primary IAB category instead of a sub-category. * Fix order of category 22
* Added new Yieldone Bid s2s Adapter * Update endpoint for yieldone bid adapter * Fixes after review for Yieldone Bid s2s Adapter * Fix typeo in Yieldone s2s Bid Adapter
#1265) and the auction with the request ID Co-authored-by: Aadesh Patel <[email protected]>
* Added header User Agent decoding * Added header User Agent decoding: unit tests * Added header User Agent decoding: unit tests * Added check UA is encoded to avoid `+` converted to space Co-authored-by: Veronika Solovei <[email protected]>
* AdGeneration Integration. * update AdGeneration adapter. fix: some methods of the adgAdapter replace to functions. fix: unmarshal functions return a pointer. fix: header is defined once. fix: return when imps is appended * update AdGeneration Adapter. add: Added a comment in usersync. add: Added a test for parameters whose ID does not exist in params_test. change: Change to query creation by net/url. Added getRawQuery Test. fix: Changed variable names related to bidRequest.
Co-authored-by: Chandra Prakash <[email protected]>
* Add app video capability to PubMatic bidder info file
I've also updated the test to avoid any confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.