[Sharethrough] Improved Headers in ad server request #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansinahar
previously approved these changes
Jul 10, 2019
hhhjort
reviewed
Jul 11, 2019
|
@maphe Just FYI, looks like you force pushed on your branch and now this PR doesn't have any files changed but still has merge conflicts.. lol. Not sure how that happened. |
|
@mansinahar thanks for the heads up, I'm investigating internally to figure out what happened, I'll restore the PR as it should be as quickly as possible |
…arethrough/prebid-server into sharethrough_master
|
@mansinahar we're back in good shape, there was some tool that got tested internally that messed up the branch. The PR is back to normal. |
hhhjort
approved these changes
Jul 17, 2019
mansinahar
approved these changes
Jul 17, 2019
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is forwarding more data to the Sharethrough ad server in order to bid more accurately:
OriginheaderX-Forwarded-ForheaderUser-Agentheader