Documenting the Appnexus test placement #962
Conversation
docs/bidders/appnexus.md
Outdated
|
|
||
| ## Test Request | ||
|
|
||
| The following test parameters can be used to verify that Prebid Server is working propely with the |
There was a problem hiding this comment.
There's a typo in this sentence with the word properly. PR LGTM otherwise 👍
docs/bidders/appnexus.md
Outdated
|
|
||
| The following test parameters can be used to verify that Prebid Server is working propely with the | ||
| Appnexus adapter. This example includes the `imp` object as the test creative must be valid for | ||
| serving into the test impression. |
There was a problem hiding this comment.
I find this sentence a bit confusing. Is it missing a coma?
This example includes the `imp` object as the test creative must be valid for serving into the test impression.
Or did we mean:
This example includes the imp object as the test creative and it must be valid for serving into the test impression.
There was a problem hiding this comment.
No, your sentence says the imp is the test creative, which is not so. We include the imp object so someone using this as a test can create an imp object that the creative can deliver in to.
|
Love the typo fix commit message @hhhjort :p Also, I wouldn't completely disagree with Gus here. I had to read that sentence a couple times too before I could properly understand it. Maybe we can try to simplify it a little bit if possible? |
|
Yes, it could probably be better. Haven't come up with an improvement yet, I am open to suggestions. |
|
Thoughts on something along the lines of: |
First pass at providing an example for other adapters to follow.