-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tags): handle non-semvers tag #360
Conversation
Hey @faust64, can you bump the version again please? I would do so, but looks like you did not allow edits from maintainers :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @faust64, can you please provide maintainers with permissions to do edits on that PR? That would help a lot. Thanks! |
I'm not sure I can. AFAIU, there should be a button on under the Unsubscribe one, in that pull request ( https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork ) I can't find it, not sure why: let me know if there's anything I can do. edit: checking with owners in the Worteks organization, I might not have those rights, maybe they would ... ... and apparently, that's more an issue of organizations in general: isaacs/github#1681 |
Can you open the PR (check the box) to allow edits from maintainer? :) Otherweise, our Bot cant merge the PR |
Sorry, as stated earlier, I don't see that checkbox. This seems to be due to my forking to my organization instead of my own account. I can re-open my PRs, forking again, if there's no way around this. |
see #384 In doubt / for my other PRs, I'm inviting @traefiker to contribute to my organization fork. |
Ensures IngressClass installation check would properly handle deployment for traefik
latest
tag.Fixes #321