Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tags): handle non-semvers tag #360

Closed
wants to merge 5 commits into from

Conversation

faust64
Copy link
Contributor

@faust64 faust64 commented Feb 16, 2021

Ensures IngressClass installation check would properly handle deployment for traefik latest tag.

Fixes #321

@ldez ldez changed the title fix(tags): handle non-semvers tag, as discussed in #321 fix(tags): handle non-semvers tag Feb 16, 2021
@SantoDE
Copy link
Contributor

SantoDE commented Mar 2, 2021

Hey @faust64,

can you bump the version again please? I would do so, but looks like you did not allow edits from maintainers :)

Copy link
Contributor

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

traefik/Chart.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SantoDE
Copy link
Contributor

SantoDE commented Mar 3, 2021

Hey @faust64,

can you please provide maintainers with permissions to do edits on that PR? That would help a lot.

Thanks!

@faust64
Copy link
Contributor Author

faust64 commented Mar 3, 2021

I'm not sure I can. AFAIU, there should be a button on under the Unsubscribe one, in that pull request ( https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork )

I can't find it, not sure why:
unsubscribe-btn

let me know if there's anything I can do.

edit: checking with owners in the Worteks organization, I might not have those rights, maybe they would ...

... and apparently, that's more an issue of organizations in general: isaacs/github#1681
I've invited you to contribute on our fork. Let me know if that's not enough.

@SantoDE
Copy link
Contributor

SantoDE commented Mar 5, 2021

Can you open the PR (check the box) to allow edits from maintainer? :)

Otherweise, our Bot cant merge the PR

@faust64
Copy link
Contributor Author

faust64 commented Mar 5, 2021

Sorry, as stated earlier, I don't see that checkbox. This seems to be due to my forking to my organization instead of my own account. I can re-open my PRs, forking again, if there's no way around this.

@faust64
Copy link
Contributor Author

faust64 commented Mar 5, 2021

see #384

In doubt / for my other PRs, I'm inviting @traefiker to contribute to my organization fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ingressclass template causes chart install to fail when using non-semver values in image.tag
4 participants