Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

"Allow edits from maintainers" should work on organisation repositories #1681

Open
xmo-odoo opened this issue Oct 18, 2019 · 1 comment
Open

Comments

@xmo-odoo
Copy link

xmo-odoo commented Oct 18, 2019

If a contributor creates a PR from a fork living under an organisation (rather than an individual), "allow edits from maintainers" is ignored and despite the "Add more commits by pushing to the <xxx> branch on <yyy>" note being present, it will not work unless the maintainer is explicitly added as a contributor to the source repository.

aikar referenced this issue in PaperMC/Paper Jun 20, 2020
Paper will routinely modify your PR for you to rebase it on latest or take care of any minor nitpicks that we can
just solve for you instead of making you go back for a trivial item.

However, if you use an Organization for the PR, this prevents Paper from doing this, and will require us to manually
merge it and close the PR instead of it being marked as the purple merged.

We much prefer to have merged PR's show as merged, so please do not use organizations repo's for PR as GitHub sadly
does not support maintainers pushing to them.

See [https://github.com/isaacs/github/issues/1681](https://github.com/isaacs/github/issues/1681)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants