Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #82: QueryMultiSeriesAsync should return "partial" #89

Merged
merged 6 commits into from
Feb 3, 2020

Conversation

tbraun-hk
Copy link
Contributor

This pull request is another attempt to implement #82
If InfluxDB is configured to have a "max-row-limit", then InfluxDB will return the flag "partial=true" to indicate that a response has been truncated due to the max-row-limit.

With this pull request, the "partial" flag is included in the IInfluxSeries and set according to the influx raw response.
A unit test that verifies the changes has been implemented, too. However, you need to have an InfluxDB system with max-row-limit set to 100.000 for this test to succeed.

@mvadu
Copy link
Contributor

mvadu commented Feb 2, 2020

Hi @tbraun-hk its been a long time since you sent this PR. Unfortunately I was little held up with life! Can you please check "Allow edits from maintainers" (refer github help) so that I can fix the test data setup script (and change log) so that we can take this PR forward?

@tbraun-hk
Copy link
Contributor Author

Hi @mvadu

I'm sorry but due to the fact that I forked your repository from my organizations account, I'm unable to give you as maintainer access to the fork as described in the link (seems to be a known github issue: isaacs/github#1681).
Instead, I've added you as a contributor to my fork so that you are able to work on the branch. Thanks a lot for maintaining this library, by the way. I really like it a lot, because it's very lean, easy to understand and use and works very good for our use cases!

Best regards,
Tobias

@mvadu mvadu merged commit 8ad79de into AdysTech:master Feb 3, 2020
@mvadu
Copy link
Contributor

mvadu commented Feb 3, 2020

@tbraun-hk Hi Tobias, I have merged the PR. Thanks a lot for kind words about the library and for your contributions. Feel free to delete the branch on your repo.

@tbraun-hk
Copy link
Contributor Author

Hi @mvadu that's great news, thanks a lot! I'll delete the branch on my repository.

@tbraun-hk tbraun-hk deleted the AddPartial branch February 3, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants