Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2839: Add support for PublishReadyToRunShowWarnings property in DotNetCorePublish #2840

Merged
merged 1 commit into from
Sep 7, 2020
Merged

GH-2839: Add support for PublishReadyToRunShowWarnings property in DotNetCorePublish #2840

merged 1 commit into from
Sep 7, 2020

Conversation

augustoproiete
Copy link
Member

Resolves #2839

DotNetCorePublish("./src/MyApp/MyApp.csproj", new DotNetCorePublishSettings
{
    // ...
    PublishReadyToRun = true,
    PublishReadyToRunShowWarnings = true, // <<<
});

@devlead
Copy link
Member

devlead commented Sep 7, 2020

@augustoproiete This looks good to be, could you please rebase against latest develop, or Allowing changes to a pull request branch created from a fork.

@augustoproiete
(cake-buildGH-2839) Add support for PublishReadyToRunShowWarnings pro…
ab8a551 
…perty in DotNetCorePublish

```csharp
DotNetCorePublish("./src/MyApp/MyApp.csproj", new DotNetCorePublishSettings
{
    // ...
    PublishReadyToRun = true,
    PublishReadyToRunShowWarnings = true, // <<<
});
```
@augustoproiete augustoproiete force-pushed the dotnetcore-publish-readytorun-showwarnings branch from 433eba5 to ab8a551 Compare September 7, 2020 14:05
@augustoproiete
Copy link
Member Author

augustoproiete commented Sep 7, 2020 •
edited
Loading

@devlead rebased on top of develop

Unfortunately the option to allow changes to a pull request branch created from a fork is not available for me (I suspect it's because my fork is in inside of an organization instead of a regular user)

devlead
devlead approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit f92781e into cake-build:develop Sep 7, 2020
@devlead
Copy link
Member

devlead commented Sep 7, 2020

@augustoproiete your changes have been merged, thanks for your contribution 👍

@augustoproiete augustoproiete deleted the dotnetcore-publish-readytorun-showwarnings branch September 7, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlead devlead devlead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for PublishReadyToRunShowWarnings property in DotNetCorePublish
2 participants
@augustoproiete @devlead