Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingressclass template causes chart install to fail when using non-semver values in image.tag #321

Closed
kevtainer opened this issue Dec 8, 2020 · 1 comment · Fixed by #384
Labels
kind/enhancement New feature or request

Comments

@kevtainer
Copy link
Contributor

I encountered this issue when trying to force the helm chart to use the latest image tag when testing a new feature. This bug cannot be worked around because the logic is always going to evaluate the SemVer in the following code (even if .Values.ingressClass.enabled evaluates to false):

https://github.com/traefik/traefik-helm-chart/blob/master/traefik/templates/ingressclass.yaml#L1

Do we need this logic check here? Is it not enough to assume the operator is enabling ingressClass when they understand their cluster has the required APIs and support? See related issue - #309

values.yaml:

        image:
          name: traefik/traefik
          tag: latest
          pullPolicy: Never

Result:

can't install chart `traefik`: template: traefik/templates/ingressclass.yaml:1:41: executing \"traefik/templates/ingressclass.yaml\" at <semverCompare \">=2.3.0\" (default .Chart.AppVersion .Values.image.tag)>: error calling semverCompare: Invalid Semantic Version"
@ldez
Copy link
Contributor

ldez commented Mar 10, 2021

Friends don't let friends get friends use latest.

You will never be able to be sure of the real version.

If you really want to take the risk, use v2 instead of latest.

I think v2 is semver compliant.

@dtomcej please comes to protect us from the latest tag 😸

@ldez ldez added kind/enhancement New feature or request and removed kind/bug/confirmed a confirmed bug (reproducible). labels Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
3 participants