Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare tokio-util 0.7.1 release #4521

Merged
merged 5 commits into from
Mar 28, 2022
Merged

chore: prepare tokio-util 0.7.1 release #4521

merged 5 commits into from
Mar 28, 2022

Conversation

djc
Copy link
Contributor

@djc djc commented Feb 21, 2022

The minimal versions fix from #4490 is required to bump h2, which is probably one of the more prominent tokio-util users.

We might want to wait to get #4520 and/or #4508 in, too?

@Darksonn Darksonn added the A-tokio-util Area: The tokio-util crate label Feb 21, 2022
@Darksonn
Copy link
Contributor

The test failure you saw might be related to the removal of path dependencies. You'll probably need to remove it in more places, or not remove it at all.

@zys864
Copy link

zys864 commented Feb 28, 2022

#4525

@Darksonn
Copy link
Contributor

Darksonn commented Mar 1, 2022

Seems like there's still some issue with two versions of the tokio crate existing simultaneously.

@zys864
Copy link

zys864 commented Mar 1, 2022

Seems like there's still some issue with two versions of the tokio crate existing simultaneously.

Seems like there isn't two versions of the tokio crate existing simultaneously.

With the dependenies

[dependencies]
# tokio-util = { version = "0.7.0", features = ["codec"] }
tokio-util = { path="../tokio/tokio-util", features = ["codec"] }
tokio = { version = "1", features = ["io-util"] }

After run cargo +nightly update -Zminimal-versions;cargo check --all-features on h2

Compiling tokio v1.6.1
Checking tokio-util v0.7.1 (/home/*/PL/Rust/tokio/tokio-util)

Cargo will use the mini support version tokio-1.6.1,and without tokio-1.0.1existing.

Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit a05135a into master Mar 28, 2022
@Darksonn Darksonn deleted the tokio-util-0.7.1 branch March 28, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio-util Area: The tokio-util crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants