Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: fix import path of CancellationToken in example code #4520

Merged

Conversation

t5kaji
Copy link
Contributor

@t5kaji t5kaji commented Feb 21, 2022

Motivation

Examples in cancellation_token.rs doesn't work since import path of CancellationToken is not up to date. I'd like to fix this to make the examples work without each developer fixing import path.

Solution

Fix import path of CancellationToken👍

@github-actions github-actions bot added the R-loom Run loom tests on this PR label Feb 21, 2022
@djc djc added the A-tokio-util Area: The tokio-util crate label Feb 21, 2022
@@ -26,7 +26,7 @@ use guard::DropGuard;
///
/// ```ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this so that they are actually compiled. (There are multiple instances of this in the file.)

Suggested change
/// ```ignore
/// ```no_run

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review :)
I changed and pushed those 👍

@Darksonn Darksonn added the M-sync Module: tokio/sync label Feb 21, 2022
@Darksonn Darksonn merged commit 503ae34 into tokio-rs:master Feb 23, 2022
@t5kaji t5kaji deleted the fix-cancellation-token-example-import branch February 23, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio-util Area: The tokio-util crate M-sync Module: tokio/sync R-loom Run loom tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants