-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: bump tokio dependency to 1.6 to satisfy minimal versions #4490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
It's really a shame we can't easily test this...
Don't we remove the path deps in release prep PRs? Maybe we could somehow make sure it gets checked at that time? |
I implemented a flag for this in cargo-minimal-versions (taiki-e/cargo-minimal-versions#4), but other workspace members have higher version requirements, so it seems that implementation of taiki-e/cargo-minimal-versions#1 is also needed to catch problems like the one this PR fixes. |
I (partially) implemented taiki-e/cargo-minimal-versions#1 in taiki-e/cargo-minimal-versions#4.
It also found other minimal versions problems. 1. mio requirement in tokio (macos specific):
UPD: filed #4492 to fix this. 2. proc-macro2 requirement in async-stream-impl:
The implementation is still incomplete and there are a few bugs, but (hopefully) |
This failed in h2 CI:
https://github.com/hyperium/h2/runs/5153518790?check_suite_focus=true
It looks like minimal versions support does not the right thing in the face of path dependencies.