schedule: add more dimension for filter metrics #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1746 +/- ##
==========================================
+ Coverage 76.83% 76.95% +0.11%
==========================================
Files 162 162
Lines 15893 15910 +17
==========================================
+ Hits 12211 12243 +32
+ Misses 2655 2638 -17
- Partials 1027 1029 +2
Continue to review full report at Codecov.
|
Luffbee
reviewed
Sep 11, 2019
server/schedule/filter/metrics.go
Outdated
| @@ -22,7 +22,7 @@ var ( | |||
| Subsystem: "schedule", | |||
| Name: "filter", | |||
| Help: "Counter of the filter", | |||
| }, []string{"action", "address", "store", "type"}) | |||
| }, []string{"action", "address", "store", "acton", "type"}) | |||
There was a problem hiding this comment.
"acton" is too similar to "action". Is there any reason for using it instead of "act-on"?
shafreeck
reviewed
Sep 12, 2019
nolouch
reviewed
Sep 17, 2019
rleungx
force-pushed
the
improve-filter-metrics
branch
from
cad5895 to
5312c6f
Compare
|
PTAL @lhy1024 |
This was referenced Sep 17, 2019
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
rleungx
force-pushed
the
improve-filter-metrics
branch
from
733b0d8 to
0a562cf
Compare
Signed-off-by: Ryan Leung <[email protected]>
rleungx
force-pushed
the
improve-filter-metrics
branch
from
0a562cf to
fe4732c
Compare
lhy1024
reviewed
Sep 18, 2019
Signed-off-by: Ryan Leung <[email protected]>
rleungx
added
the
status/can-merge
|
/run-all-tests |
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Nov 7, 2019
Signed-off-by: Ryan Leung <[email protected]>
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Nov 7, 2019
Signed-off-by: Ryan Leung <[email protected]>
sre-bot
pushed a commit
that referenced
this pull request
Nov 8, 2019
Signed-off-by: Ryan Leung <[email protected]>
nolouch
pushed a commit
to nolouch/pd
that referenced
this pull request
Nov 12, 2019
Signed-off-by: Ryan Leung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
We have added the filter related metrics in grafana, but it's hard to understand how a filter acts on the checkers or the schedulers. It only shows the total filter number which is useless.
What is changed and how it works?
This PR adds a new dimension named
ActOnfor each filter to indicate that each scheduler or checker is affected by the kind of the filter.Also this PR removes two unused filters:
disconnectFilterandrejectLeaderFilterCheck List
Tests
Related changes
tidb-ansiblerepository