*: improve more metrics #1761
Merged
*: improve more metrics #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1761 +/- ##
==========================================
+ Coverage 77.19% 77.27% +0.08%
==========================================
Files 163 163
Lines 16408 16417 +9
==========================================
+ Hits 12666 12687 +21
+ Misses 2687 2676 -11
+ Partials 1055 1054 -1
Continue to review full report at Codecov.
|
rleungx
added
the
do-not-merge/work-in-progress
nolouch
reviewed
Sep 17, 2019
server/checker/metrics.go
Outdated
| @@ -23,8 +23,17 @@ var ( | |||
| Name: "event_count", | |||
| Help: "Counter of checker events.", | |||
| }, []string{"type", "name"}) | |||
|
|
|||
| processStatusCounter = prometheus.NewGaugeVec( | |||
lhy1024
reviewed
Sep 17, 2019
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
rleungx
force-pushed
the
replica-metrics
branch
from
95f25a7 to
0ae6c46
Compare
rleungx
changed the title
rleungx
removed
the
do-not-merge/work-in-progress
Signed-off-by: Ryan Leung <[email protected]>
lhy1024
approved these changes
Sep 23, 2019
disksing
approved these changes
Sep 23, 2019
disksing
added
the
status/can-merge
|
/run-all-tests |
|
@rleungx merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
At present, it's hard to know the process status of making replicas for offline or down stores. We might not know why the operator is failed to be created.
What is changed and how it works?
This PR adds a new metrics named
processStatusCounterto record the failure reason when creating the operator for the offline or down store. Also, this PR renames some labels to make them more clear.Pros and cons:
Pros:
Cons:
checkerCounter.UPDATE:
According to the comments, reuse
checkerCounter.Check List
Tests