address the comment

Signed-off-by: Ryan Leung <[email protected]>
tikv · Sep 17, 2019 · 5312c6f · 5312c6f
1 parent c67d3c5
commit 5312c6f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/server/checker/replica_checker.go b/server/checker/replica_checker.go
@@ -42,16 +42,20 @@ type ReplicaChecker struct {
 }
 
 // NewReplicaChecker creates a replica checker.
-func NewReplicaChecker(cluster schedule.Cluster, classifier namespace.Classifier) *ReplicaChecker {
+func NewReplicaChecker(cluster schedule.Cluster, classifier namespace.Classifier, n ...string) *ReplicaChecker {
+	name := replicaCheckerName
+	if len(n) != 0 {
+		name = n[0]
+	}
 	filters := []filter.Filter{
-		filter.NewOverloadFilter(replicaCheckerName),
-		filter.NewHealthFilter(replicaCheckerName),
-		filter.NewSnapshotCountFilter(replicaCheckerName),
-		filter.NewPendingPeerCountFilter(replicaCheckerName),
+		filter.NewOverloadFilter(name),
+		filter.NewHealthFilter(name),
+		filter.NewSnapshotCountFilter(name),
+		filter.NewPendingPeerCountFilter(name),
 	}
 
 	return &ReplicaChecker{
-		name:       replicaCheckerName,
+		name:       name,
 		cluster:    cluster,
 		classifier: classifier,
 		filters:    filters,

diff --git a/server/schedulers/balance_region.go b/server/schedulers/balance_region.go
@@ -187,7 +187,7 @@ func (s *balanceRegionScheduler) transferPeer(cluster schedule.Cluster, region *
 	}
 	scoreGuard := filter.NewDistinctScoreFilter(s.GetName(), cluster.GetLocationLabels(), stores, source)
 	hitsFilter := s.hitsCounter.buildTargetFilter(s.GetName(), cluster, source)
-	checker := checker.NewReplicaChecker(cluster, nil)
+	checker := checker.NewReplicaChecker(cluster, nil, s.GetName())
 	storeID, _ := checker.SelectBestReplacementStore(region, oldPeer, scoreGuard, hitsFilter)
 	if storeID == 0 {
 		schedulerCounter.WithLabelValues(s.GetName(), "no_replacement").Inc()