Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nebula_node_container)!: nebula single-node architecture support #261

Draft
wants to merge 3 commits into
base: tier4/universe
Choose a base branch
from

Conversation

mojomex
Copy link

@mojomex mojomex commented Jul 18, 2024

Description

This PR makes the changes necessary to support the new Nebula single-node architecture.
These changes can be summarized as:

  • merge the separate Nebula nodes into one in the launch file
  • remove obsolete parameters such as delay_monitor_ms
  • find and read default sensor config file in case none is specified. Parameters specified as arguments will override the values in the file

⚠️ This PR has to be merged in a coordinated manner with the corresponding PRs listed below. The timeline is currently being discussed.

Related links

Internal Tickets:

Depends on:

Related PRs:

  • TBA

How was this PR tested?

  • TBA

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

Nebula should experience less packet loss & other issues. The hardware monitor is now launched when launch_driver is true (was not launched at all before). No other behavioral changes expected.

@mojomex mojomex self-assigned this Jul 18, 2024
@mojomex mojomex force-pushed the refactor/nebula_single_node_support branch from a4d7e0c to 438c482 Compare July 18, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant