Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export canonical_{in/pro}jection #1196

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

lgoettgens
Copy link
Contributor

I do not see a deeper reason why not to. They are already used in Oscar for direct sums of modules and will be of use for Lie algebras in the near future.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.13% ⚠️

Comparison is base (6a580bd) 74.44% compared to head (dde545d) 74.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
- Coverage   74.44%   74.32%   -0.13%     
==========================================
  Files         346      346              
  Lines      110747   110744       -3     
==========================================
- Hits        82445    82309     -136     
- Misses      28302    28435     +133     
Files Changed Coverage Δ
src/GrpAb/GrpAbFinGen.jl 81.11% <ø> (-0.10%) ⬇️

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit 7fc2453 into thofma:master Sep 13, 2023
@lgoettgens lgoettgens deleted the lg/canonical-inj branch September 13, 2023 19:37
lgoettgens added a commit to lgoettgens/Oscar.jl that referenced this pull request Sep 19, 2023
fingolfin pushed a commit to oscar-system/Oscar.jl that referenced this pull request Sep 19, 2023
* Cleanup after thofma/Hecke.jl#1196

* Fix for 0-th powers

* Fix 0-dim Lie algebras

* Add tests for 0-dim modules
fieker pushed a commit to oscar-system/Oscar.jl that referenced this pull request Sep 29, 2023
* Cleanup after thofma/Hecke.jl#1196

* Fix for 0-th powers

* Fix 0-dim Lie algebras

* Add tests for 0-dim modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants