LieAlgebras: Follow-up to #2753 #2818
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2818 +/- ##
==========================================
- Coverage 80.81% 80.63% -0.19%
==========================================
Files 456 456
Lines 64539 64672 +133
==========================================
- Hits 52159 52149 -10
- Misses 12380 12523 +143 |
| @@ -140,21 +140,17 @@ end | |||
| ############################################################################### | |||
|
|
|||
| @doc raw""" | |||
| (L::LinearLieAlgebra{C})(m::MatElem{C}) -> LieAlgebraElem{C} | |||
| coerce_to_lie_algebra_elem(L::LinearLieAlgebra{C}, x::MatElem{C}) -> LinearLieAlgebraElem{C} | |||
There was a problem hiding this comment.
Hmm, so L(m) is changed to coerce_to_lie_algebra_elem(L,m) -- why?
There was a problem hiding this comment.
Because L(m) is already in use for m being a coefficient vector (of size 1 x dim(L)). For dimensions 1 and 0, it is ambiguous which of the two you mean
There was a problem hiding this comment.
Why are coefficient vectors matrices and not vectors?
There was a problem hiding this comment.
That's because I started with AbstractAlgebra's Generic.FreeModuleElem and adapted it to my needs.
I should probably change it to SRow{C} and change module action matrices and home matrices to sparse matrices as well. But as that is a larger change, I would like to split that into a new PR.
coerce_to_lie_algebra_elem(L, m) will then be removed again in favor of L(m).
* Cleanup after thofma/Hecke.jl#1196 * Fix for 0-th powers * Fix 0-dim Lie algebras * Add tests for 0-dim modules
This includes some small adaptions and fixes that I missed in #2753.