Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LieAlgebras: Constructions for module homs #2753

Merged
merged 18 commits into from
Sep 18, 2023

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Aug 31, 2023

This builds upon #2644 and thus includes that PR. Once #2644 gets merged, I will rebase this PR.

Introduces new constructions for Lie algebra module homs:

  • injections/projections for direct sums
  • hom_tensor
  • hom_direct_sum
  • lift hom $V \to W$ to $T^k V \to T^k W$
  • lift hom $V \to W$ to $\bigwedge^k V \to \bigwedge^k W$
  • lift hom $V \to W$ to $S^k V \to S^k W$

While doing that, refactor the constructions of the modules and put more helpful stuff in attribute storage:

  • direct sum
  • tensor product
  • tensor power
  • exterior power
  • symmetric power

More changes:

  • add is_welldefined to be able to check that even if using check=false in the hom constructor
  • add zero_map
  • change the internals of modules to use right multiplication with a matrix as the action

Missing:

  • Handle 0-th powers

@lgoettgens lgoettgens added enhancement New feature or request WIP NOT ready for merging labels Aug 31, 2023
@lgoettgens lgoettgens force-pushed the lg/lie-hom-constructions branch 2 times, most recently from c10bde7 to fbf4b9e Compare September 1, 2023 07:42
@lgoettgens lgoettgens force-pushed the lg/lie-hom-constructions branch from fbf4b9e to cce6d9b Compare September 1, 2023 09:35
@lgoettgens lgoettgens force-pushed the lg/lie-hom-constructions branch from 9d009f9 to c4d431d Compare September 1, 2023 13:36
@lgoettgens lgoettgens force-pushed the lg/lie-hom-constructions branch from 2879b6b to 7776c60 Compare September 1, 2023 13:52
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #2753 (3d4a213) into master (d42af1a) will increase coverage by 0.33%.
Report is 48 commits behind head on master.
The diff coverage is 77.73%.

@@            Coverage Diff             @@
##           master    #2753      +/-   ##
==========================================
+ Coverage   73.26%   73.60%   +0.33%     
==========================================
  Files         450      455       +5     
  Lines       63973    64675     +702     
==========================================
+ Hits        46872    47604     +732     
+ Misses      17101    17071      -30     
Files Changed Coverage
experimental/LieAlgebras/src/LieAlgebras.jl ø
...rimental/LieAlgebras/test/LieAlgebraModule-test.jl ø
experimental/LieAlgebras/src/LieAlgebraModule.jl 70.77%
...xperimental/LieAlgebras/src/LieAlgebraModuleHom.jl 81.72%
...xperimental/LieAlgebras/test/LieAlgebraHom-test.jl 96.00%
experimental/LieAlgebras/src/LieAlgebraHom.jl 100.00%

@fieker
Copy link
Contributor

fieker commented Sep 6, 2023

is there any reason to not bind hom_tensor and hom_direct_sum to hom as well? As in
hom(M, N, V) for M and N being tensor products: call hom_tensor, for both being ...?

@lgoettgens
Copy link
Member Author

is there any reason to not bind hom_tensor and hom_direct_sum to hom as well? As in hom(M, N, V) for M and N being tensor products: call hom_tensor, for both being ...?

I am not sure if I understand you correctly. Are you proposing to add hom_tensor (and hom_direct_sum) instead as methods to hom?
As similar functions (hom_tensor and hom_product) already exist for ModuleFP, I would keep it here for the time being as is, and then discuss your proposal in a new issue for both ModuleFP and LieAlgebraModule.

@lgoettgens lgoettgens marked this pull request as ready for review September 11, 2023 09:45
@lgoettgens lgoettgens removed the WIP NOT ready for merging label Sep 11, 2023
@lgoettgens
Copy link
Member Author

There is a little bit of cleanup possible once thofma/Hecke.jl#1196 is available.

@lgoettgens lgoettgens force-pushed the lg/lie-hom-constructions branch from 51047f5 to f6073f5 Compare September 11, 2023 13:37
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@fingolfin fingolfin merged commit cd151b1 into oscar-system:master Sep 18, 2023
fingolfin pushed a commit that referenced this pull request Sep 19, 2023
* Cleanup after thofma/Hecke.jl#1196

* Fix for 0-th powers

* Fix 0-dim Lie algebras

* Add tests for 0-dim modules
fieker pushed a commit that referenced this pull request Sep 29, 2023
* Cleanup after thofma/Hecke.jl#1196

* Fix for 0-th powers

* Fix 0-dim Lie algebras

* Add tests for 0-dim modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic: LieTheory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants