-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LieAlgebras: Constructions for module homs #2753
LieAlgebras: Constructions for module homs #2753
Conversation
c10bde7
to
fbf4b9e
Compare
fbf4b9e
to
cce6d9b
Compare
9d009f9
to
c4d431d
Compare
2879b6b
to
7776c60
Compare
Codecov Report
@@ Coverage Diff @@
## master #2753 +/- ##
==========================================
+ Coverage 73.26% 73.60% +0.33%
==========================================
Files 450 455 +5
Lines 63973 64675 +702
==========================================
+ Hits 46872 47604 +732
+ Misses 17101 17071 -30 |
is there any reason to not bind hom_tensor and hom_direct_sum to hom as well? As in |
I am not sure if I understand you correctly. Are you proposing to add |
There is a little bit of cleanup possible once thofma/Hecke.jl#1196 is available. |
51047f5
to
f6073f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks
* Cleanup after thofma/Hecke.jl#1196 * Fix for 0-th powers * Fix 0-dim Lie algebras * Add tests for 0-dim modules
* Cleanup after thofma/Hecke.jl#1196 * Fix for 0-th powers * Fix 0-dim Lie algebras * Add tests for 0-dim modules
This builds upon #2644 and thus includes that PR. Once #2644 gets merged, I will rebase this PR.Introduces new constructions for Lie algebra module homs:
hom_tensor
hom_direct_sum
While doing that, refactor the constructions of the modules and put more helpful stuff in attribute storage:
More changes:
is_welldefined
to be able to check that even if usingcheck=false
in thehom
constructorzero_map
Missing: