-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize port to Python 3 / Gtk 3 #1022
Open
cydanil
wants to merge
157
commits into
thinkle:master
Choose a base branch
from
kirienko:upstream_pr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's ensure topic branches are in a usable state before pull requests are made
Use setuptools.find_packages to avoid manually maintaining the package list. This restores __init__.py to the gourmet/exporters directory so it can be discovered. This also eliminates a bug in the previous crawl_plugins function that erroneously discovered __pycache__ and other non-source directories.
We probably don't want to include tests when building non-source distributions, and non-development installs may not have the dependencies installed to run them anyway.
This can cause installation to fail if we end up trying to import a dependency that isn't (yet) installed.
Generally the project root will be our current working directory, which Python automatically includes in its system path. Since gourmet is no longer in the project root, we must now explicitly install it to run it, which helps ensure we have a working, installable distribution.
We can now just "graft" the src directory, which means any additional package data will be automatically included.
Gourmet can now be installed in one step and plugin-specific dependencies can be optionally installed using 'extras_require'. setuptools is removed as a requirement since this provides the build system and must already be installed for anything to work.
A development install can now be installed in one step using 'development.in'. This installs gourmet in "editable" mode as well as additional development dependencies. 'development.txt' is renamed to 'development.in' to support pinning of dependencies (using, e.g., pip-tools). Unfortunately, this only works for local installs since gourmet is a "local" package and results in a non-portable, absolute file path being generated in 'development.txt'. Consequently, 'development.txt' is added to .gitignore, and build environments can just use 'development.in' directly. wheel is removed as a development dependency since it must already be installed in order for pip to build wheels when installing dependencies.
But do allow them to be manually triggered. This reverts commit 65ffca7.
Reorganize source directory
Fixes imports from ica.se, nytimes, and allrecipes.
* Set images to None in database upon deletion * Remove deprecated to_unicode helper function
This copies the FAQ and LICENSE into the package so they are available as a resource.
This option and setting appear to been removed since at least commit 648a40f in October 2008.
All package data is now maintained within the gourmet package itself, so no need to look for plugins in a build directory.
The dialog used to expand offscreen as images were added
* Rename callback functions * Remove unused import
* Update scrape-schema-recipe version * Update INSTALL.md with version 1 links
cydanil
changed the title
Fix most Python3 port issues
Finalize port to Python 3 / Gtk 3
Jul 1, 2021
Correct ImageBox.commit type hinting; reformat ImageBox.__init__
How to install on raspberry pi? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings further fixes, which makes Gourmet operate almost as well as the Python 2 version.
It fixes:
It introduces:
Ctrl-C
and context menu.Downloads are available here !
Thanks!
Cyril :)
closes #1014
closes #1017
closes #1016
closes #1012
closes #1011
closes #996
closes #994
closes #962
closes #955