Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ImageBrowserDialog #352

Merged
merged 2 commits into from
Jun 27, 2021

Conversation

cydanil
Copy link
Collaborator

@cydanil cydanil commented Jun 27, 2021

Description

This PR improves gourmet.image_utils.ImageBrowser by making the image retrieval a background thread, thus not blocking until all images are retrieved, and making the dialog scrollable.

How Has This Been Tested?

This was tested by importing a web recipe.

Screenshots (if appropriate):

The dialog used to expand each time an image was added, often making the dialog expand beyond the screen:
expanded_image_browser

It now retains its size:
scrolled_image_browser

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cydanil cydanil changed the title Make web import image browser scrollable Improve ImageBrowserDialog Jun 27, 2021
@cydanil cydanil merged commit ab2c4cf into kirienko:master Jun 27, 2021
@cydanil cydanil deleted the fix/scrollable_image_browser branch June 27, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant