Fix pdf export when locale is set #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cydanil
added a commit
to cydanil/gourmand
that referenced
this pull request
Jul 20, 2021
* Fix pdf export when a locale is set kirienko/gourmet#363 * Only scale available reportlab attributes kirienko/gourmet#365 * Use latest Python3.8 for building AppImage kirienko/gourmet#367 Sorry for the squashed changes.
cydanil
added a commit
to cydanil/gourmand
that referenced
this pull request
Jul 20, 2021
* Fix pdf export when a locale is set kirienko/gourmet#363 * Only scale available reportlab attributes kirienko/gourmet#365 * Use latest Python3.8 for building AppImage kirienko/gourmet#367 Sorry for the squashed changes.
cydanil
added a commit
to cydanil/gourmand
that referenced
this pull request
Jul 20, 2021
* Fix pdf export when a locale is set kirienko/gourmet#363 * Only scale available reportlab attributes kirienko/gourmet#365 * Use latest Python3.8 for building AppImage kirienko/gourmet#367 Sorry for the squashed changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #362: there was an issue where the window for offering PDF export options weren't correctly set when switching from one locale to the other.
This was because of the preferences are saved with the option in a locale, but fail to load when another locale is used.
One way to fix this is to validate the values loaded from the preferences.toml file before using them, but this issue occurs not often enough to warrant such a complicated solution.
Thus, the values are now stored in english, and looked up in whatever locale is now used.
This also solve the problem, where we now have fixed locale handling, and people might now be using the application in their respective locales.
How Has This Been Tested?
This was tested by exporting one or several recipe(s) with
LANGUAGESset tode_DE.utf-8,fr_FR.utf-8, andru_RU.utf-8.Off this, a minimal unit test was created.
Screenshots (if appropriate):
Types of changes
Checklist: