Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin_loader refactor gone wrong #353

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

cydanil
Copy link
Collaborator

@cydanil cydanil commented Jun 28, 2021

Description

During refactoring, self.errors was changed to a set, when it's actually a dictionary.
This issue arises when plugins are not correctly set up.

How Has This Been Tested?

This was tested by launching the application without any of the plugins being available.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cydanil cydanil merged commit a66b89d into kirienko:master Jun 28, 2021
@cydanil cydanil deleted the fix/plugin_loader_bug branch June 28, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant