Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chart: allow specifying imagePullSecrets #354

Closed
wants to merge 1 commit into from
Closed

feat: chart: allow specifying imagePullSecrets #354

wants to merge 1 commit into from

Conversation

USA-RedDragon
Copy link
Contributor

@USA-RedDragon USA-RedDragon commented Feb 10, 2024

Context

Choices

  • Docker Hub's rate limit is easily hit when running a large Kubernetes cluster, therefore it's prudent to allow users of the chart to authenticate to raise the rate limit.

Test instructions

  1. helm template palworld ./palworld/ -f ./palworld/values.yaml --set 'server.image.imagePullSecrets[0].name=registry-docker-hub' then verified the imagePullSecrets on the Deployment was valid

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@USA-RedDragon USA-RedDragon mentioned this pull request Feb 10, 2024
3 tasks
@Twinki14
Copy link
Contributor

I'm going to go ahead and make this fix in the new helm-chart repository, Twinki14/palworld-server-chart#1

But I don't want to steal your thunder, so if you'd like to make a PR there I'd be happy to merge it!

@USA-RedDragon
Copy link
Contributor Author

Feel free to put it in the helm chart yourself if it's easier, it's more important that the pull secrets be configurable than the idea that I get credit! Happy to do whatever's easiest!

@USA-RedDragon USA-RedDragon deleted the helm-imagepullsecrets branch February 11, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants