Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Publish to GHCR #353

Merged
merged 3 commits into from
Feb 11, 2024
Merged

feat: Publish to GHCR #353

merged 3 commits into from
Feb 11, 2024

Conversation

USA-RedDragon
Copy link
Contributor

@USA-RedDragon USA-RedDragon commented Feb 10, 2024

Context

Choices

  • I added jobs in parallel with the Docker Hub release jobs to push to GHCR
  • I added a workflow to publish developer images to GHCR as well

Test instructions

  1. Just ran the workflows in my fork, resulting in: https://github.com/USA-RedDragon/palworld-server-docker/pkgs/container/palworld-server-docker

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

Copy link
Contributor

@Twinki14 Twinki14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of brand new workflows, we should keep docker image publishing all in the same workflow

Ideally this would be building the image then pushing to both registries in the same workflow job

This will keep our workflow logic organized and efficient

@USA-RedDragon
Copy link
Contributor Author

USA-RedDragon commented Feb 11, 2024

Question, are you referring to the extra ghcr.yaml workflow for the GHCR Development Builds? Or do you mean in release.yaml I should be pushing to both GHCR and Docker Hub in the same job? (Or both?).

Edit: did both

Thanks!

This is a squash containing:

fix: ci: merge GHCR+Docker Hub developer image workflow

ci: release: combine GHCR and DockerHub releases
Copy link
Contributor

@Twinki14 Twinki14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Could not have done it better myself

@thijsvanloef thijsvanloef merged commit d88925b into thijsvanloef:main Feb 11, 2024
7 checks passed
@USA-RedDragon USA-RedDragon deleted the main branch February 11, 2024 18:00
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants