Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chart: RCON is a TCP-based protocol #355

Closed
wants to merge 1 commit into from
Closed

fix: chart: RCON is a TCP-based protocol #355

wants to merge 1 commit into from

Conversation

USA-RedDragon
Copy link
Contributor

@USA-RedDragon USA-RedDragon commented Feb 10, 2024

Context

  • Fixes the default chart values to use the appropriate protocol for RCON

Choices

  • RCON is on TCP not UDP

Test instructions

  1. Deployed in USA-RedDragon/home-cluster-flux@ca34e53

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@win5923
Copy link
Contributor

win5923 commented Feb 10, 2024

Hi @USA-RedDragon, after the discussions in Discord and considering the increasing complexity of the docker image, it has been decided that the Helm chart will be better managed in a dedicated Helm chart repository.

Ref: #335

@Twinki14
Copy link
Contributor

Twinki14 commented Feb 10, 2024

Heya, as @win5923 mentioned, we're planning to move the Helm chart out of this repository

This specific issue was actually noticed by someone and fixed in a wip PR found in the new repository, Twinki14/palworld-server-chart#1

@USA-RedDragon
Copy link
Contributor Author

USA-RedDragon commented Feb 11, 2024

Thanks for clarifying. One question for my own understanding, is that going to be the new home of the chart, or will the chart end up back in thijsvanloef's user? Asking so I know where to send #354

Edit: answered in #354

@USA-RedDragon USA-RedDragon deleted the rcon-is-tcp branch February 11, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants