Partial Response : "Use Partial Response" enabled by default #6977
Conversation
There was a problem hiding this comment.
Thanks! Generally looks good, but I wonder if you came across the issue mentioned in comment: #6270 (comment)
| @@ -272,6 +276,7 @@ const PanelList: FC<RouteComponentProps & PathPrefixProps> = ({ pathPrefix = '' | |||
| defaultStep={defaultStep} | |||
| defaultEngine={defaultEngine} | |||
| queryHistoryEnabled={enableQueryHistory} | |||
| usePartialResponse={usePartialResponse === 'true'} | |||
There was a problem hiding this comment.
Do we need the equality check here?
There was a problem hiding this comment.
Yaa actually i used it to resolve a error which ensure it's always a boolean.
There was a problem hiding this comment.
Isn't this done in the js/ts world by doing a double negation, like !!usePartialResponse? I see it often where people want to convert something to boolean.
There was a problem hiding this comment.
Thank you @douglascamata made changes suggested by you its working ! can review now
Hello @saswatamcode worked on the comment you suggested tested it on my local machine you can review it again ! |
Vanshikav123
force-pushed
the
patch-partialResponse
branch
from
5a7256f
to
0cc822b
Compare
|
@Vanshikav123 Please sign off DCO |
Rebuild Signed-off-by: Vanshika <[email protected]>
Vanshikav123
force-pushed
the
patch-partialResponse
branch
from
9c9b6da
to
e77caa8
Compare
Done ! |
Changes
I have made relevant changes in the codebase such that #6270 issue is resolved and Use Partial Response checkbox is enabled by default.