Use Partial Response should be enabled by default

[SanthoshiMekala]

Hi Team,

We have a requirement that Use Partial Response should be enabled in thanos query UI by default. I tried configuring the "--query.partial-response" flag in thanos-query. But I do not see it is enabled in UI and when querying also, its not sending the flag as true in UI. I need Use Partial Response to be enabled in thanos query UI by default. Is there any flag or config that we need to do for this requirement?

Thanos: 0.29.0
Prometheus: 2.40.0.

Thank you!

[fpetkovski]

There is no good way to do this right now, but we might be able to propagate the flag to the UI.

[SanthoshiMekala]

Hi @fpetkovski how to propagate the flag to the UI?

[saswatamcode]

I think we might be able to do this. The UI already calls api/v1/status/flag, so we can just pass it as a prop to the panel component. We are trying something similar in #6234

[SanthoshiMekala]

We are using Prometheus and Thanos components as is and we are not overriding any code or fields.. Is there any way to send that flag to the UI using thanos query tags that can be configured in thanos-query container cinfiguration?
This is our current thanos-query configuration.

• args:
  - query
  - --log.level=error
  - --query.active-query-path=/tmp
  - --query.partial-response
  - --query.replica-label=replica
  - --store=dnssrv+prometheus-headless:10901
  - --store=dnssrv+thanos-ruler-headless:10901
  - --web.external-prefix=thanosquery

[saswatamcode]

I don't think there is any such config option for this presently.

[bwplotka]

Ideally we could use this issue to solve ALL flag propagation issues, not only this flag, WDYT?

It's great issue for our Thanos ContribFest session (https://sched.co/1HzdF), let's add some "Acceptance Criteria"

[SanthoshiMekala]

Hi @bwplotka sorry I missed your reply. The acceptance criteria should be like below.

• UI flags for Thanos query should be configurable
• Example will be Use Partial Response should be configured in the thanos query container configuration

[mak2002]

Hey there, I'd like to take a shot at this issue!

[mak2002]

Hey @saswatamcode ,

As you suggested, I am able to configure default behaviour of "Use Partial Response" option by passing down the response from query.partial-response flag to the Panel component.
But whenever I toggle this option and re-render the page it resets to the default setting which we fetch from api/v1/status/flags. How should I persist the change? Is it okay if I try to store it in local storage?

As stated above in acceptance criteria, should I also implement support for UI flags like Enable Autocompletion, Enable Highlighting?

[Vanshikav123]

Hello @saswatamcode @bwplotka @yeya24 i have raised a PR for this issue and it is also verified by me please review it !!