Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial Response : "Use Partial Response" enabled by default #6977

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Partial Response : "Use Partial Response" enabled by default #6977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/ui/react-app/src/pages/graph/Panel.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ const defaultProps: PanelProps = {
analyze: false,
disableAnalyzeCheckbox: false,
},
onUsePartialResponseChange: (): void => {
// Do nothing.
},
onOptionsChanged: (): void => {
// Do nothing.
},
Expand All @@ -47,6 +50,7 @@ const defaultProps: PanelProps = {
enableHighlighting: true,
enableLinter: true,
defaultEngine: 'prometheus',
usePartialResponse: true,
};

describe('Panel', () => {
Expand Down
23 changes: 21 additions & 2 deletions pkg/ui/react-app/src/pages/graph/Panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,11 @@ export interface PanelProps {
stores: Store[];
enableAutocomplete: boolean;
enableHighlighting: boolean;
usePartialResponse: boolean;
enableLinter: boolean;
defaultStep: string;
defaultEngine: string;
onUsePartialResponseChange: (value: boolean) => void;
}

interface PanelState {
Expand Down Expand Up @@ -93,7 +95,7 @@ export const PanelDefaultOptions: PanelOptions = {
maxSourceResolution: '0s',
useDeduplication: true,
forceTracing: false,
usePartialResponse: false,
usePartialResponse: true,
storeMatches: [],
engine: '',
analyze: false,
Expand Down Expand Up @@ -166,6 +168,13 @@ class Panel extends Component<PanelProps & PathPrefixProps, PanelState> {

componentDidMount(): void {
this.executeQuery();
const storedValue = localStorage.getItem('usePartialResponse');
if (storedValue !== null) {
// Set the default value in state and local storage
this.setOptions({ usePartialResponse: true });
this.props.onUsePartialResponseChange(true);
localStorage.setItem('usePartialResponse', JSON.stringify(true));
}
}

executeQuery = (): void => {
Expand Down Expand Up @@ -346,7 +355,17 @@ class Panel extends Component<PanelProps & PathPrefixProps, PanelState> {
};

handleChangePartialResponse = (event: React.ChangeEvent<HTMLInputElement>): void => {
this.setOptions({ usePartialResponse: event.target.checked });
let newValue = event.target.checked;

const storedValue = localStorage.getItem('usePartialResponse');

if (storedValue === 'true') {
newValue = true;
}
this.setOptions({ usePartialResponse: newValue });
this.props.onUsePartialResponseChange(newValue);

localStorage.setItem('usePartialResponse', JSON.stringify(event.target.checked));
};

handleStoreMatchChange = (selectedStores: any): void => {
Expand Down
9 changes: 9 additions & 0 deletions pkg/ui/react-app/src/pages/graph/PanelList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ interface PanelListProps extends PathPrefixProps, RouteComponentProps {
enableLinter: boolean;
defaultStep: string;
defaultEngine: string;
usePartialResponse: boolean;
}

export const PanelListContent: FC<PanelListProps> = ({
Expand All @@ -44,6 +45,7 @@ export const PanelListContent: FC<PanelListProps> = ({
enableLinter,
defaultStep,
defaultEngine,
usePartialResponse,
...rest
}) => {
const [panels, setPanels] = useState(rest.panels);
Expand Down Expand Up @@ -95,6 +97,9 @@ export const PanelListContent: FC<PanelListProps> = ({
},
]);
};
const handleUsePartialResponseChange = (value: boolean): void => {
localStorage.setItem('usePartialResponse', JSON.stringify(value));
};

return (
<>
Expand Down Expand Up @@ -128,6 +133,8 @@ export const PanelListContent: FC<PanelListProps> = ({
defaultEngine={defaultEngine}
enableLinter={enableLinter}
defaultStep={defaultStep}
usePartialResponse={usePartialResponse}
onUsePartialResponseChange={handleUsePartialResponseChange}
/>
))}
<Button className="d-block mb-3" color="primary" onClick={addPanel}>
Expand Down Expand Up @@ -161,6 +168,7 @@ const PanelList: FC<RouteComponentProps & PathPrefixProps> = ({ pathPrefix = ''
} = useFetch<FlagMap>(`${pathPrefix}/api/v1/status/flags`);
const defaultStep = flagsRes?.data?.['query.default-step'] || '1s';
const defaultEngine = flagsRes?.data?.['query.promql-engine'];
const usePartialResponse = flagsRes?.data?.['query.partial-response'] || true;

const browserTime = new Date().getTime() / 1000;
const { response: timeRes, error: timeErr } = useFetch<{ result: number[] }>(`${pathPrefix}/api/v1/query?query=time()`);
Expand Down Expand Up @@ -272,6 +280,7 @@ const PanelList: FC<RouteComponentProps & PathPrefixProps> = ({ pathPrefix = ''
defaultStep={defaultStep}
defaultEngine={defaultEngine}
queryHistoryEnabled={enableQueryHistory}
usePartialResponse={!!usePartialResponse}
isLoading={storesLoading || flagsLoading}
/>
</>
Expand Down
Loading