Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add toggle to enable/disable metric autocomplete #3381

Merged
merged 4 commits into from
Oct 30, 2020

Conversation

ipstatic
Copy link
Contributor

This change adds a toggle to enable or disable the metric autocomplete
functionality. By default it is enabled.

Signed-off-by: Jarod Watkins [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Added toggle to enable/disable metric autocomplete functionality in the new UI.

Verification

Tested locally against production data.

This change adds a toggle to enable or disable the metric autocomplete
functionality. By default it is enabled.

Signed-off-by: Jarod Watkins <[email protected]>
Signed-off-by: Jarod Watkins <[email protected]>
Signed-off-by: Jarod Watkins <[email protected]>
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please do make assets and commit the result? We really need to fix the CI part here :(

Signed-off-by: Jarod Watkins <[email protected]>
@ipstatic
Copy link
Contributor Author

Could you please do make assets and commit the result? We really need to fix the CI part here :(

Done. No worries.

ipstatic added a commit to ipstatic/prometheus that referenced this pull request Oct 30, 2020
This change adds a toggle to enable or disable the metric autocomplete
functionality. By default it is enabled. This is a port of a change I
did in [Thanos][1].

[1]: thanos-io/thanos#3381

Signed-off-by: Jarod Watkins <[email protected]>
@ipstatic
Copy link
Contributor Author

I also implemented this change "upstream" in Prometheus

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we have quick screenshot how this checkbox looks like? (:

Thanks!

@ipstatic
Copy link
Contributor Author

ipstatic commented Oct 30, 2020

Can we have quick screenshot how this checkbox looks like? (:

localhost_3000_new_graph_g0 expr= g0 tab=1 g0 stacked=0 g0 range_input=1h g0 max_source_resolution=0s g0 deduplicate=1 g0 partial_response=0 g0 store_matches=%5B%5D(iPad Pro)

Copy link
Member

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. LGTM.
Thanks!

@bwplotka bwplotka merged commit ab3ed4c into thanos-io:master Oct 30, 2020
@ipstatic
Copy link
Contributor Author

Oh I forgot to add a changelog entry! How should I correct?

@bwplotka
Copy link
Member

bwplotka commented Oct 30, 2020 via email

juliusv pushed a commit to prometheus/prometheus that referenced this pull request Nov 2, 2020
* UI: Add toggle to enable/disable metric autocomplete

This change adds a toggle to enable or disable the metric autocomplete
functionality. By default it is enabled. This is a port of a change I
did in [Thanos][1].

[1]: thanos-io/thanos#3381

Signed-off-by: Jarod Watkins <[email protected]>

* Adding full variable name

Signed-off-by: Jarod Watkins <[email protected]>
@ipstatic
Copy link
Contributor Author

ipstatic commented Nov 2, 2020

FYI I have created another PR to bring in changes suggested by Prometheus developers: #3391

Oghenebrume50 pushed a commit to Oghenebrume50/thanos that referenced this pull request Dec 7, 2020
* UI: Add toggle to enable/disable metric autocomplete

This change adds a toggle to enable or disable the metric autocomplete
functionality. By default it is enabled.

Signed-off-by: Jarod Watkins <[email protected]>

* Fixing tests

Signed-off-by: Jarod Watkins <[email protected]>

* Fixing lint suggestions

Signed-off-by: Jarod Watkins <[email protected]>

* Run make assets

Signed-off-by: Jarod Watkins <[email protected]>
Signed-off-by: Oghenebrume50 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants