Querier UI: Updating enable/disable metric automcomplete with upstream #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bringing in changes suggested by Prometheus developers to keep in sync. Also updated CHANGELOG. Signed-off-by: Jarod Watkins <[email protected]>
|
FYI I attempted a |
2 tasks
Yeah, this happens sometimes, when |
Signed-off-by: Jarod Watkins <[email protected]>
|
That did it, thanks! |
|
CircleCI does not want to cooperate today and simply returns 400 when trying to resubmit the payload for this pull request. The tests pass and everything looks good, thank you! |
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
thanos-io#3391) * Querier UI: Updating enable/disable metric automcomplete with upstream Bringing in changes suggested by Prometheus developers to keep in sync. Also updated CHANGELOG. Signed-off-by: Jarod Watkins <[email protected]> * Make assets Signed-off-by: Jarod Watkins <[email protected]> Signed-off-by: Oghenebrume50 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing in changes suggested by Prometheus developers to keep in sync.
Also updated CHANGELOG.
Signed-off-by: Jarod Watkins [email protected]