query: /graph unusable on large __name__ set due to autocomplete

[clhain]

thanos version: 0.11.0

We run a query instance that has a very large set of unique metric names (we're working to reduce them). Attempting to use the GUI at /graph causes the browser to go unresponsive for a long time as it grabs the list of values (a few seconds) and then renders the dropdown (a few dozen seconds). During that time the window is unresponsive.

Grafana helpfully disables the autocomplete feature on large sets, is it possible to do something similar here?

[GiedriusS]

There is this: #2150. Just need someone to follow up and rebase on master.

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[bwplotka]

Still a problem.

[bwplotka]

And something to tackle on React UI

cc @prmsrswt

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[bwplotka]

still to fix on React UI potentially

…

On Wed, 3 Jun 2020 at 10:50, stale[bot] ***@***.***> wrote: Hello 👋 Looks like there was no activity on this issue for last 30 days. *Do you mind updating us on the status?* Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command <https://probot.github.io/apps/reminders/> if you wish to be reminded at some point in future. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2361 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVA3OYC5BXYNFQYKU622ZTRUYMGXANCNFSM4LZP7QVQ> .

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[onprem]

@clhain can you check if it's still a problem with the new React UI? We limit the dom rendering to 100 items at max, so it's shouldn't be a problem now.

https://github.com/thanos-io/thanos/blob/master/pkg/ui/react-app/src/pages/graph/ExpressionInput.tsx#L89

[clhain]

Hey, sorry I missed this update. I had a look at it in .13 and it's still unusable. Could be the match function running slowly as opposed to the actual rendering? Let me know if there's something else that would help debug, and thanks.

[GiedriusS]

If it's still laggy then you must have so many metrics. label_names and label_values APIs now support time limits so maybe that could be leveraged in the future? 🤔

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗

[ipstatic]

This is still an issue, even with thew new interface.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[jameskranz]

This is still an issue, although #3381 helps mitigate the issue. It makes thanos usable with huge metric sets, but means autocomplete is unavailable.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[CNG]

Still an issue.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗

[onprem]

Still valid. There's #4030 which switches the autocomplete with a codemirror based editor. We need to check if the performance is better or worse with the new editor enabled.

[Nexucis]

I tested with ~150k metrics. Works well, it's just a bit slow due to the network mainly. It would maybe need a way to warm the cache embedded in the PromQL editor

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[yeya24]

Looks like we can close this issue if it works well with the new editor.

[kalebris]

This still seems to be a problem. It seems to be working much better on Firefox, but on Chrome we are still seeing huge delays due to autocomplete. After typing in 1 character the ui freezes up for a good while (30 seconds or so) before the options appear.