replace bingo with go 1.17 go run commands

[codefromthecrypt]

Is your feature request related to a problem? Please describe.
Right now, we use a modified version of bingo to pin versions without tainting GOBIN's default. For example, this is used to invoke known versions of hugo, goreleaser, golint, etc

Describe the solution you'd like
Inside the Makefile, declare paths for each main tool and do go run instead. This reduces the toolchain knowledge to run the project and conversion to make-unfriendly env like windows more straightforward.

go run now accepts arguments with version suffixes (for example, go run example.com/[email protected]). This causes go run to build and run packages in module-aware mode, ignoring the go.mod file in the current directory or any parent directory, if there is one. This is useful for running executables without installing them or without changing dependencies of the current module.

Describe alternatives you've considered
Leaving it alone. There is some benefit to leaving it as depending on how go run in 1.17 is implemented, it might be inefficient to repeatedly run the same command.

Additional context
https://tip.golang.org/doc/go1.17#go-command

[codefromthecrypt]

cc @nacx

[mathetake]

this is good to know this, thanks for raising here 😄

[codefromthecrypt]

It is possible that when we use this, we can avoid needing cygwin bash anymore. So, possibly worth revisiting the github action that currently installs cygwin-bash and overrides the shell in order to translate paths so bingo's Variables.mk doesn't die (#325)

[nacx]

When I was trying to upgrade the monorepo to 1.17 and move away from Bingo, I found this error when trying to use Kustomize:

go generate ./...
+ set -o allexport
+ source ../../../../scripts/build/tools.mk
++ GOIMPORTS=golang.org/x/tools/cmd/[email protected]
++ GOLANGCI_LINT=github.com/golangci/golangci-lint/cmd/[email protected]
++ KUSTOMIZE=sigs.k8s.io/kustomize/kustomize/[email protected]
++ LICENSER=github.com/liamawhite/[email protected]
+ set +o allexport
+ go run sigs.k8s.io/kustomize/kustomize/[email protected] build sources/managementplane -o managementplaneoperator.yaml
go run: sigs.k8s.io/kustomize/kustomize/[email protected] (in sigs.k8s.io/kustomize/kustomize/[email protected]):
	The go.mod file for the module providing named packages contains one or
	more exclude directives. It must not contain directives that would cause
	it to be interpreted differently than if it were the main module.

Looks like go run does not run if the referenced modules contain replace or exclude directives. I found some of the rationale here: golang/go#40276.

Have you found similar issues? And if so, do you have a workaround? Given how messy the dependency hell problem is in all languages, we could expect exlude/replace directives to be not a rare thing.

[codefromthecrypt]

well we don't have need for excludes since axing the istio deps :D

[codefromthecrypt]

serious answer: 😎 personally, I would try to push that onto the tools themselves, ex keep a bingo file around for things not supported, yet, or just do the same thing ad-hoc in your make file. Raise an issue with the repo that has the conflicts and at least inform them that their tool doesn't work because they are needing to do replaces and whatnot. Some libraries have alternatives that don't have dependency hell, and in any case you can help build pressure on the original go issue that was denied, and through all of it have paperwork in case things change (ex the links to the issues that might resolve)

[nacx]

Looks like it already was reported. Let's see! kubernetes-sigs/kustomize#3618