Removes bingo for go run
#350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses versioned syntax of `go run` brought to us in 1.17 https://golang.org/doc/go1.17 In doing so, we can remove the complexity of bingo and also simplify its impact on windows. Fixes #314 Signed-off-by: Adrian Cole <[email protected]>
| @@ -72,9 +72,8 @@ jobs: | |||
| with: | |||
| path: | # TODO: go build cache if we care, noting it is OS-specific | |||
There was a problem hiding this comment.
I will sort out the build cache in a different PR as it requires handling Os-specifics!
Signed-off-by: Adrian Cole <[email protected]>
|
might have a glitch on goreleaser on windows. regardless will be green prior to merge! |
added 2 commits
August 24, 2021 13:08
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
|
note: this is slower than before because go rebuilds each time. However, this time spent is less important to me than lack of cruft, so think it is a better tradeoff. @mathetake wdyt? |
| @for f in `find . -name '*.go'`; do \ | ||
| awk '/^import \($$/,/^\)$$/{if($$0=="")next}{print}' $$f > /tmp/fmt; \ | ||
| mv /tmp/fmt $$f; \ | ||
| $(GOIMPORTS) -w -local github.com/tetratelabs/func-e $$f; \ |
There was a problem hiding this comment.
doing this in a loop is as time consuming as trying to parse wtf ^^ was trying to do
Makefile
Outdated
| @echo "--- win-bin ---" | ||
| @GOOS=windows GOARCH=amd64 $(GORELEASER) build --snapshot --single-target --rm-dist | ||
| # We can't pass GOOS=windows GOARCH=amd64 as it ends up interpreted by go, not goreleaser. |
There was a problem hiding this comment.
this is annoying to build all when you only need windows, but I think we will be killing goreleaser soon anyway
Signed-off-by: Adrian Cole <[email protected]>
mathetake
reviewed
Aug 24, 2021
Co-authored-by: Takeshi Yoneda <[email protected]>
|
thanks takeshi-san! |
codefromthecrypt
pushed a commit
that referenced
this pull request
Aug 29, 2021
This will be used in the new release process to generate draft release notes that a person edits before clicking publish. Notably, this correctly annotates co-authors, which is a common practice in func-e, but easy to miss. Ex. (nevermind the 'aster' as I'm hacking this to show pending notes) ```bash $ .github/workflows/release_notes.sh master ``` --- func-e aster supports X and Y and notably fixes Z TODO: classify the below into up to 4 major headings and the rest as bulleted items in minor changes --- ee700a1 Converts e2e to new Makefile (#356) Adrian Cole, Co-authored-by: Dhi Aurrahman <[email protected]> 83e7c30 updates last known Envoy to 1.19.1 (#355) Adrian Cole, f975609 Aligns make to func-e color scheme (#354) Adrian Cole, 551840f Scaffold a new Makefile (#353) Adrian Cole, 877a72e Removes bingo for `go run` (#350) Adrian Cole, Co-authored-by: Takeshi Yoneda <[email protected]> 12a74b1 Adds vanity downloads (#351) Adrian Cole, 0f313c8 Pares down code to work around flake (#349) Adrian Cole, e74c0b7 Removes test utilities for built-ins (#347) Adrian Cole, 41c2742 Cleans up tests (#348) Adrian Cole, 17375b4 Updates to Go 1.17 (#346) Adrian Cole, 6ae5d48 Corrects manifest path Adrian Cole, a9ccc4d fixes auth Adrian Cole, a4bc290 Fixes glitches in package update script (#344) Adrian Cole, --- Don't forget to cite who was involved and why nothing trivial please! func-e aster was possible thanks to the following contributors: Adrian Cole Dhi Aurrahman Takeshi Yoneda Signed-off-by: Adrian Cole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses versioned syntax of
go runbrought to us in 1.17https://golang.org/doc/go1.17
In doing so, we can remove the complexity of bingo and also simplify its
impact on windows.
Fixes #314