Uses make in windows #325
Uses make in windows #325
Conversation
codefromthecrypt
force-pushed
the
try-choco
branch
2 times, most recently
from
573a234 to
44735a0
Compare
|
main goal of this is not just coherency, but allowing us to use this to test using make as a part of #316 |
|
looks like it didn't like caching cygwin.. |
|
last didn't error, but it didn't cache either. I'm trying explicit dir for chocolatey |
|
I'll pull the choco package caching out of scope, as it isn't working, nor is the dominant time in the workflow anyway. |
This consolidates the build by using the same matrix for Linux, MacOS and Windows. To do the latter requires installation of CygWin, and to get GHA to use that requires overriding the `shell`. One other quirk is that when you are running tasks via cygwin, it resets the CWD. To avoid that, this adds the GITHUB_WORKSPACE to `.bashrc`. Finally, this dodges various newline related problems and comments why. Unrelated changes including updating syntax that allows us to break-apart actions/cache and fixing some lint errors that the build never caught because lint wasn't run on Windows. Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
try-choco
branch
from
2ddd9d7 to
cd134a5
Compare
Signed-off-by: Adrian Cole <[email protected]>
| @@ -54,7 +54,7 @@ test: | |||
| .PHONY: e2e | |||
| e2e: $(BIN) | |||
| @echo "--- e2e ---" | |||
| @E2E_FUNC_E_PATH=$(PWD)/$(BIN) go test -parallel 1 -v -failfast ./e2e | |||
There was a problem hiding this comment.
changing this allowed one less translation problem in cygwin. It is now allowed to be and defaults to relative to the project root.
|
|
||
| defaults: | ||
| run: | ||
| shell: ${{ matrix.shell || 'bash' }} |
There was a problem hiding this comment.
I didn't know that we can use|| stuff in the GHA expression 😄
|
Thanks for the look! |
|
with some adjustments I was able to use the built-in make and save a lot of time and crazy config #327 |
|
#328 simplified further |
This consolidates the build by using the same matrix for Linux, MacOS
and Windows. To do the latter requires installation of CygWin, and to
get GHA to use that requires overriding the
shell. One other quirk isthat when you are running tasks via cygwin, it resets the CWD. To avoid
that, this adds the GITHUB_WORKSPACE to
.bashrc. Finally, this dodgesvarious newline related problems and comments why.
Unrelated changes including updating syntax that allows us to
break-apart actions/cache and fixing some lint errors that the build
never caught because lint wasn't run on Windows.