-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Change global.json roll-forward policy from latestPatch
to latestMinor
#1230
chore: Change global.json roll-forward policy from latestPatch
to latestMinor
#1230
Conversation
So that contributors can work on Testcontainers with the latest dotnet SDK.
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this lead to incompatibilities if developers use the latest SDK with features that aren't available in previous major versions? Locally, you can use the DOTNET_ROLL_FORWARD
environment variable or set user-specific project settings.
Well, those are SDK features so that should not have any impact on the Testcontainers projects themselves. But using When working on #1231 I had to modify
The Maintaining the
I even fixed the official documentation that was wrong! dotnet/docs#35775 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am aware of the limitations and issues.
The
DOTNET_ROLL_FORWARD
environment variable is for the dotnet runtime and is unrelated to the SDK.
Ah, I mixed that up — I remember using DOTNET_ROLL_FORWARD
some time ago when I encountered similar issues, but I believe that was when I was running the Sonar CLI tool, IIRC. If we can make it easier for developers to build the projects, it is definitely something we should do. Thanks.
latestPatch
to latestMinor
latestPatch
to latestMinor
What does this PR do?
This pull request changes the roll forward policy from
latestPatch
tolatestMinor
.Why is it important?
Contributors can work on Testcontainers with the latest dotnet SDK. Note that it's impossible to compile the projects with the latest SDK (version 8.0.303) and the
latestPatch
policy.Related issues
None