feat: Improve parsing of Docker image tag version MatchVersion(Predicate<Version>)
#1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle major-only version number, e.g. `2` without any dot that Version.TryParse doesn't parse.
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
changed the title
MatchVersion(Predicate<Version>)
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request handles major-only version number, e.g.
2without any dot thatVersion.TryParsedoesn't parse. Matching a version was recently introduced in #1213 but did not account for major-only versions which are quite common in Docker image tags.Why is it important?
Verifying a version on the major part of the tag version is sometimes enough.
Related issues
Relates #1213
How to test this PR
The
MatchVersion_ReturnsTrue_WhenVersionMatchesPredicatetest was updated from aFactto aTheoryhandling many different version number inputs.