Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global.json #16

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Fix global.json #16

merged 1 commit into from
Oct 27, 2021

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Oct 27, 2021

The SDK version must have major.minor.patch else it doesn't work as expected (i.e. always use the latest available SDK, completely ignoring the global.json settings).

  • With with following .NET SDKs installed:
2.1.818 [/usr/local/share/dotnet/sdk]
3.1.414 [/usr/local/share/dotnet/sdk]
5.0.402 [/usr/local/share/dotnet/sdk]
6.0.100-rc.2.21505.57 [/usr/local/share/dotnet/sdk]
  • With "rollForward": "latestMinor"
    • With "version": "5.0" in global.json
      dotnet --version returns 6.0.100-rc.2.21505.57
    • With "version": "5.0.300" in global.json
      dotnet --version returns 5.0.402

That's a lot of words to say that you can't use 5.0 but must use 5.0.402.

The SDK version must have major.minor.patch else it doesn't work as expected (i.e. always use the latest available SDK, completely ignoring the `global.json` settings).

- With with following .NET SDKs installed:

```
2.1.818 [/usr/local/share/dotnet/sdk]
3.1.414 [/usr/local/share/dotnet/sdk]
5.0.402 [/usr/local/share/dotnet/sdk]
6.0.100-rc.2.21505.57 [/usr/local/share/dotnet/sdk]
```

- With "rollForward": "latestMinor"
  - With "version": "5.0" in global.json  
    ❌ `dotnet --version` returns 6.0.100-rc.2.21505.57
  - With "version": "5.0.300" in global.json  
    ✅ `dotnet --version` returns 5.0.402


That's a lot of words to say that you can't use `5.0` but must use `5.0.402`.
@xoofx xoofx merged commit b82c1a7 into xoofx:master Oct 27, 2021
@xoofx
Copy link
Owner

xoofx commented Oct 27, 2021

Thanks! Indeed, I discovered that on other projects as well, and I had to revert from 5.0 to 5.0.300, forgot that I also changed Tomlyn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants