Updated node_pools variable documentation

[neelesh9795]

Added the wrong file last time. Updated the autogen/README.md

[morgante]

Please check the formatting of this (you can preview on GitHub). I'd suggest formatting as a table.

[morgante]

Please recheck requirements and provide defaults from the codebase.

[morgante]

Not required, has a default: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/cluster.tf#L150

[morgante]

Not required.

[morgante]

Please add a column explaining defaults.

[morgante]

@neelesh9795 https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/cluster.tf#L299

[aaron-lane]

This should incorporate the addition of node_locations in #303.

[thecodejunkie]

Does auto_upgrade actuall have a default value of false?

I just tried this module with the following node pool definition

{
    autoscaling        = false
    name               = var.default_node_pool.name
    machine_type       = var.default_node_pool.machine_type
}

after I ran terraform plan I could see the following in the output for the node pool

+management {
  + auto_repair  = true
  + auto_upgrade = true
}

but if I explicitly add auto_upgrade = false then I correctly displayed as

+ management {
   + auto_repair  = true
   + auto_upgrade = false
}

[morgante]

The default depends on whether the cluster is regional or zonal: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main.tf#L62

[thecodejunkie]

@morgante ah! Then I humble request that default values, that depend on whether the cluster is regional or zonal, are also reflected in this part of the documentation. Keep up the awesome work!

[morgante]

Agreed. @neelesh9795 please make sure to update with that.

[thecodejunkie]

@neelesh9795 please also consider sorting the table in alphabetical order 🤗

[aaron-lane]

This table must include node_count which was added in #313.

[neelesh9795]

Closing this due to merge conflicts. Re opening at #331