Add documentation for node_pools #331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR adds a new "safer" GKE module. The module includes hardening suggestions from multiple sources.
The PR adds a new "safer" GKE module. The module includes hardening suggestions from multiple sources.
…ubernetes-engine into safer-cluster
The PR adds a new "safer" GKE module. The module includes hardening suggestions from multiple sources.
… with oauth scopes
adding commits from master
…-modules/bugfix/zonal-region Compute region output for zonal clusters
morgante
reviewed
Dec 3, 2019
| | min_count | Minimum number of nodes in the NodePool. Must be >=0 and <= max_count. Should be used when autoscaling is true | 1 | Optional | | ||
| | name | The name of the node pool | | Required | | ||
| | node_count | The number of nodes in the nodepool when autoscaling is false. Otherwise defaults to 1 | | Required (when autoscaling is false) | | ||
| | node_locations | The list of zones in which the cluster's nodes are located. Nodes must be in the region of their regional cluster or in the same region as their cluster's zone for zonal clusters | " " | Optional | |
There was a problem hiding this comment.
This is only available on beta clusters, please make sure to only include beta features inside beta conditionals: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/cluster.tf.tmpl#L321
morgante
reviewed
Dec 4, 2019
There was a problem hiding this comment.
@neelesh9795 Please rebase on master. It looks like you merged or otherwise polluted your history incorrectly, because the diff is now extremely noisy.
|
Opened a new PR #368 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45